Skip to content

v1.14.4#3589

Merged
fujimotos merged 1 commit into
fluent:masterfrom
fujimotos:sf/v1.14.4
Jan 6, 2022
Merged

v1.14.4#3589
fujimotos merged 1 commit into
fluent:masterfrom
fujimotos:sf/v1.14.4

Conversation

@fujimotos

Copy link
Copy Markdown
Contributor
  • This is the pull request for upcoming v1.14.4 release.
  • If anything is missing from my release note, please comment here.
    (I'm going to fast-forward this branch tomorrow)

@fujimotos
fujimotos requested review from ashie and kenhys January 5, 2022 08:50
@fujimotos fujimotos mentioned this pull request Jan 5, 2022
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
@kenhys

kenhys commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

It looks good if the above 2 issues were fixed.

Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
@fujimotos

fujimotos commented Jan 6, 2022

Copy link
Copy Markdown
Contributor Author

So I was poking around the CHANGELOG.md this morning. I ended up adding a few fixes:

  • The bug-fix section contains more detailed explanation about what was fixed.
    • e.g. On macOS with Ruby 2.7/3.0, out_file fails to write events if append is true.
  • Use backticks to escape underscore characters.

@kenhys kenhys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fujimotos
fujimotos merged commit d1f33da into fluent:master Jan 6, 2022
@fujimotos
fujimotos deleted the sf/v1.14.4 branch January 6, 2022 04:41
@fujimotos

Copy link
Copy Markdown
Contributor Author

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants