tests: use never instead of dont_allow - #4671
Merged
Merged
Conversation
Watson1978
force-pushed
the
use-never
branch
2 times, most recently
from
October 16, 2024 10:26
86c93d6 to
7b97c00
Compare
Watson1978
marked this pull request as ready for review
October 17, 2024 00:34
daipom
requested changes
Oct 17, 2024
daipom
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this fix!
Please fix the following points.
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Contributor
|
I'm checking if this failure on Windows has something to do with this change. |
Contributor
|
I have confirmed those Windows failures have nothing to do with this change. Currently, |
daipom
pushed a commit
that referenced
this pull request
Nov 29, 2024
Backported from a2b935a. --- If it use the object applied dont_allow in the other test through ObjectSpace.each_object, it will cause the error. To relax object constraints, this patch will use never instead. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Nov 29, 2024
Backported from a2b935a. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> --- If it use the object applied dont_allow in the other test through ObjectSpace.each_object, it will cause the error. To relax object constraints, this patch will use never instead. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
pushed a commit
that referenced
this pull request
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4063
What this PR does / why we need it:
If it use the object applied
dont_allowin the other test throughObjectSpace.each_object, it will cause the error.To relax object constraints, this patch will use
neverinstead.See sample code in #4063 (comment)
Docs Changes:
Release Note: