Skip to content

in_tail: fix error when files without read permission are included in glob patterns #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Watson1978 merged 4 commits into from
Nov 25, 2025
Merged

in_tail: fix error when files without read permission are included in glob patterns #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2a1722
test_in_tail: add test to read root's log file
Watson1978 Nov 21, 2025
f8f385c
in_tail: fix error when files without read permission are included in…
Watson1978 Nov 21, 2025
1d7abe5
test_in_tail: add link to issue as comment
Watson1978 Nov 22, 2025
0337ea9
test_in_tail: remove unused variable
Watson1978 Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/fluent/plugin/in_tail.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def initialize
@shutdown_start_time = nil
@metrics = nil
@startup = true
@capability = Fluent::Capability.new(:current_process)
Comment thread
Watson1978 marked this conversation as resolved.
end

desc 'The paths to read. Multiple paths can be specified, separated by comma.'
Expand Down Expand Up @@ -195,7 +196,6 @@ def configure(conf)
@dir_perm = system_config.dir_permission || Fluent::DEFAULT_DIR_PERMISSION
# parser is already created by parser helper
@parser = parser_create(usage: parser_config['usage'] || @parser_configs.first.usage)
@capability = Fluent::Capability.new(:current_process)
if @read_bytes_limit_per_second > 0
if !@enable_watch_timer
raise Fluent::ConfigError, "Need to enable watch timer when using log throttling feature"
Expand Down
16 changes: 16 additions & 0 deletions test/plugin/test_in_tail.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2648,6 +2648,22 @@ def test_no_warn_with_directory_permission
end
end

def test_other_user_owned_files
Comment thread
ashie marked this conversation as resolved.
# https://github.com/fluent/fluentd/issues/5141
omit "Cannot test with root user" if Process::UID.eid == 0
omit "NTFS doesn't support UNIX like permissions" if Fluent.windows?

config = config_element('', '', {
'tag' => "tail",
'path' => "/var/log/*.log",
'format' => 'none',
"pos_file" => "#{@tmp_dir}/tail.pos",
})
assert_nothing_raised do
create_driver(config, false)
end
end

def test_shutdown_timeout
Fluent::FileWrapper.open("#{@tmp_dir}/tail.txt", "wb") do |f|
# Should be large enough to take too long time to consume
Expand Down