Fix out_forward keepalive reuse after remote close - #5309
Merged
Watson1978 merged 1 commit intoApr 17, 2026
Merged
Conversation
Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
Watson1978
approved these changes
Apr 13, 2026
Watson1978
left a comment
Watson1978
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Thanks a lot for this fix!
Watson1978
added
the
backport to v1.19
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
**Which issue(s) this PR fixes**: Fixes #5269 Fixes #4618 **What this PR does / why we need it**: This PR fixes a keepalive socket reuse bug in `out_forward`. When a cached keepalive connection has already been closed by the remote side, `out_forward` could pick that socket back up and try to write to it again. In the reported TLS/NLB setup, that leaves the flush thread spinning on a dead socket and can drive CPU usage to 100%. The fix is to validate cached sockets before reusing them. If a socket has already become unreadable, closed, or otherwise looks no longer safe to reuse, it is discarded and a new connection is created instead. This keeps `out_forward` from reusing half-closed keepalive sockets and avoids the busy-loop behavior described in the issue. This PR also adds regression coverage to make sure a socket that was closed by the peer is not reused from the keepalive cache. **Docs Changes**: None. **Release Note**: - out_forward: avoid reusing closed keepalive sockets after remote disconnects Signed-off-by: aviralgarg05 <gargaviral99@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978
pushed a commit
that referenced
this pull request
Apr 20, 2026
…5309) (#5343) **Which issue(s) this PR fixes**: Fixes #5269 Fixes #4618 **What this PR does / why we need it**: This PR fixes a keepalive socket reuse bug in `out_forward`. When a cached keepalive connection has already been closed by the remote side, `out_forward` could pick that socket back up and try to write to it again. In the reported TLS/NLB setup, that leaves the flush thread spinning on a dead socket and can drive CPU usage to 100%. The fix is to validate cached sockets before reusing them. If a socket has already become unreadable, closed, or otherwise looks no longer safe to reuse, it is discarded and a new connection is created instead. This keeps `out_forward` from reusing half-closed keepalive sockets and avoids the busy-loop behavior described in the issue. This PR also adds regression coverage to make sure a socket that was closed by the peer is not reused from the keepalive cache. **Docs Changes**: None. **Release Note**: - out_forward: avoid reusing closed keepalive sockets after remote disconnects Signed-off-by: aviralgarg05 <gargaviral99@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Aviral Garg <gargaviral99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #5269
Fixes #4618
What this PR does / why we need it:
This PR fixes a keepalive socket reuse bug in
out_forward.When a cached keepalive connection has already been closed by the remote side,
out_forwardcould pick that socket back up and try to write to it again. In the reported TLS/NLB setup, that leaves the flush thread spinning on a dead socket and can drive CPU usage to 100%.The fix is to validate cached sockets before reusing them. If a socket has already become unreadable, closed, or otherwise looks no longer safe to reuse, it is discarded and a new connection is created instead.
This keeps
out_forwardfrom reusing half-closed keepalive sockets and avoids the busy-loop behavior described in the issue.This PR also adds regression coverage to make sure a socket that was closed by the peer is not reused from the keepalive cache.
Docs Changes:
None.
Release Note: