Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add explicit initialization of TestWidgets binding to all breaking unit tests#2005

Merged
mehmetf merged 1 commit into
flutter-team-archive:masterfrom
mehmetf:master
Aug 23, 2019
Merged

Add explicit initialization of TestWidgets binding to all breaking unit tests#2005
mehmetf merged 1 commit into
flutter-team-archive:masterfrom
mehmetf:master

Conversation

@mehmetf

@mehmetf mehmetf commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

This is a tests only change so I did not increment versions.

@mehmetf mehmetf requested a review from bparrishMines August 23, 2019 01:05
@mehmetf mehmetf changed the title Fix tests after breaking change https://github.com/flutter/flutter/pulll/38464 Add explicit initialization of TestWidgets binding to all breaking unit tests Aug 23, 2019
@mehmetf

mehmetf commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

@collinjackson FYI

@collinjackson

collinjackson commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Closing this one as it's redundant with firebase/flutterfire#11 Edit: never mind, this one does all the non-Flutterfire plugins

@collinjackson collinjackson reopened this Aug 23, 2019
@collinjackson collinjackson self-requested a review August 23, 2019 20:25
@mehmetf mehmetf merged commit ffe12d4 into flutter-team-archive:master Aug 23, 2019
@collinjackson

collinjackson commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Seems like we missed sensors somehow

https://cirrus-ci.com/task/4869691366965248

I've opened a PR: #2009

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants