This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider_linux] Migration to null safety#3262
Closed
yash1200 wants to merge 8 commits into
Closed
Conversation
Contributor
Author
|
Hey @ditman kindly have a look at this one. |
passsy
approved these changes
Nov 19, 2020
Hixie
approved these changes
Nov 20, 2020
Hixie
left a comment
Contributor
There was a problem hiding this comment.
LGTM though it looks like the analysis isn't happy.
Contributor
Author
|
@Hixie I think the analyze test errors are not related to this PR. |
yash1200
commented
Nov 28, 2020
| xdg_directories: ^0.1.0 | ||
| path_provider_platform_interface: ^1.0.1 | ||
| path: ^1.8.0-nullsafety.3 | ||
| xdg_directories: ^0.1.2 |
Contributor
Author
There was a problem hiding this comment.
The PR to migrate xdg_directories to nnbd is here flutter/packages#250
|
Sorry for the late notice. The nnbd branch has been merged into master. |
Contributor
Author
|
Sure I'll reopen the PR on master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates
path_provider_linuxto null safety.Related Issues
Fixes flutter/flutter#70219
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?