Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider_linux] Migration to null safety#3262

Closed
yash1200 wants to merge 8 commits into
flutter-team-archive:nnbdfrom
yash1200:path
Closed

[path_provider_linux] Migration to null safety#3262
yash1200 wants to merge 8 commits into
flutter-team-archive:nnbdfrom
yash1200:path

Conversation

@yash1200

Copy link
Copy Markdown
Contributor

Description

Migrates path_provider_linux to null safety.

Related Issues

Fixes flutter/flutter#70219

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@yash1200 yash1200 changed the title Path provider Linux migrated to nnbd [path_provider_linux] Migration to null safety Nov 10, 2020
@yash1200

yash1200 commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

Hey @ditman kindly have a look at this one.

@Hixie Hixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though it looks like the analysis isn't happy.

@yash1200

Copy link
Copy Markdown
Contributor Author

@Hixie I think the analyze test errors are not related to this PR.

xdg_directories: ^0.1.0
path_provider_platform_interface: ^1.0.1
path: ^1.8.0-nullsafety.3
xdg_directories: ^0.1.2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR to migrate xdg_directories to nnbd is here flutter/packages#250

@blasten

blasten commented Dec 14, 2020

Copy link
Copy Markdown

Sorry for the late notice. The nnbd branch has been merged into master.
You might need to reopen this PR.

@yash1200

Copy link
Copy Markdown
Contributor Author

Sure I'll reopen the PR on master branch.

@yash1200 yash1200 closed this Dec 15, 2020
@yash1200 yash1200 deleted the path branch December 15, 2020 05:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants