Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

adding support auth link for Twitter#697

Merged
kroikie merged 2 commits into
flutter-team-archive:masterfrom
ko2ic:firebase_auth_twitter_link
Oct 3, 2018
Merged

adding support auth link for Twitter#697
kroikie merged 2 commits into
flutter-team-archive:masterfrom
ko2ic:firebase_auth_twitter_link

Conversation

@ko2ic

@ko2ic ko2ic commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ko2ic ko2ic force-pushed the firebase_auth_twitter_link branch from 9f1d9cf to d9dea82 Compare August 1, 2018 12:17
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 1, 2018
@ko2ic ko2ic force-pushed the firebase_auth_twitter_link branch 2 times, most recently from 4804eb6 to 6228808 Compare August 1, 2018 13:54
@kroikie kroikie self-assigned this Aug 2, 2018

@kroikie kroikie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note in the change log and bump the version number to 0.6.0

@ko2ic ko2ic force-pushed the firebase_auth_twitter_link branch from 6228808 to a72a386 Compare September 14, 2018 07:48
@ko2ic

ko2ic commented Sep 14, 2018

Copy link
Copy Markdown
Contributor Author

@kroikie I wrote the change log. Please review again.

@ko2ic ko2ic force-pushed the firebase_auth_twitter_link branch 2 times, most recently from ce0c529 to a58314d Compare September 14, 2018 09:03
@ko2ic

ko2ic commented Sep 14, 2018

Copy link
Copy Markdown
Contributor Author

@kroikie In addition, please also review #703 .

* Link federated Twitter auth provider credentials to a user account.
* This fix calls method ```linkWithCredential()``` like other providers (facebook, google).
@ko2ic ko2ic force-pushed the firebase_auth_twitter_link branch from a58314d to 990b35a Compare October 1, 2018 08:36
@kroikie kroikie merged commit df583bc into flutter-team-archive:master Oct 3, 2018
@ko2ic ko2ic deleted the firebase_auth_twitter_link branch October 4, 2018 08:36
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants