This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Support sign-in with Github and linking Github accounts to existing users#768
Merged
bparrishMines merged 6 commits intoNov 8, 2018
Merged
Conversation
filleduchaos
force-pushed
the
feat/add-github
branch
from
1654206 to
467ff10
Compare
bparrishMines
force-pushed
the
feat/add-github
branch
4 times, most recently
from
471f18a to
e3449db
Compare
bparrishMines
force-pushed
the
feat/add-github
branch
from
e3449db to
732a352
Compare
bparrishMines
approved these changes
Nov 8, 2018
bparrishMines
left a comment
bparrishMines
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good! Thanks for contributing!
bparrishMines
changed the title
|
@filleduchaos Hello, how is this intended to be used? Where do we get the Token from? |
Contributor
Author
|
@lukepighetti Hey sorry - saw this late! Much like with any OAuth thing you'd get the token back from the provider (in this case, likely through a Sign In With Github web flow) |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…isting users (flutter-team-archive#768)" This reverts commit eabf8af.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fulfills feature request: flutter/flutter#21331