This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add the ability for ML Kit to create image from bytes#901
Closed
bparrishMines wants to merge 25 commits into
Closed
Add the ability for ML Kit to create image from bytes#901bparrishMines wants to merge 25 commits into
bparrishMines wants to merge 25 commits into
Conversation
bparrishMines
commented
Nov 17, 2018
|
|
||
| switch (call.method) { | ||
| case "BarcodeDetector#detectInImage": | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
Moved this to top of onMethodCall for all detectors
kroikie
approved these changes
Nov 20, 2018
kroikie
left a comment
kroikie
left a comment
Contributor
There was a problem hiding this comment.
Small adjustment to handling invalid rotation value. Otherwise LGTM.
| case ImageRotation.rotation_270: | ||
| return 270; | ||
| default: | ||
| return -1; |
Contributor
There was a problem hiding this comment.
Could we just return 0 in this case?
Contributor
Author
There was a problem hiding this comment.
Good idea. Done and added an assert.
Contributor
Author
|
Closed for improved PR #971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.