Skip to content

Improves potential errors of SendData/ReceiveData on the Clipboard #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 5 commits into from
Feb 12, 2026
Merged

Improves potential errors of SendData/ReceiveData on the Clipboard #152

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5c3783
Cancel pending GetData callback and null check input
JSUYA Feb 6, 2026
d3951ce
Close fd on early SendData error paths
JSUYA Feb 6, 2026
693290d
Add null check event in SendData/ReceiveData
JSUYA Feb 6, 2026
0258a9e
++
JSUYA Feb 11, 2026
c2a6db6
++
JSUYA Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion flutter/shell/platform/tizen/tizen_clipboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,23 @@ TizenClipboard::~TizenClipboard() {
}

void TizenClipboard::SendData(void* event) {
if (!event) {
return;
}
auto* send_event = reinterpret_cast<Ecore_Wl2_Event_Data_Source_Send*>(event);
if (!send_event->type || strcmp(send_event->type, kMimeTypeTextPlain)) {
FT_LOG(Error) << "Invaild mime type.";
if (send_event->fd >= 0) {
close(send_event->fd);
}
return;
}

if (send_event->serial != selection_serial_) {
FT_LOG(Error) << "The serial doesn't match.";
if (send_event->fd >= 0) {
close(send_event->fd);
}
Comment thread
JSUYA marked this conversation as resolved.
return;
}

Expand All @@ -65,6 +74,9 @@ void TizenClipboard::SendData(void* event) {
}

void TizenClipboard::ReceiveData(void* event) {
if (!event) {
return;
}
auto* ready_event =
reinterpret_cast<Ecore_Wl2_Event_Offer_Data_Ready*>(event);
if (ready_event->data == nullptr || ready_event->len < 1) {
Expand Down Expand Up @@ -129,7 +141,6 @@ bool TizenClipboard::GetData(ClipboardCallback on_data_callback) {
FT_LOG(Error) << "ecore_wl2_dnd_selection_get() failed.";

if (on_data_callback_) {
on_data_callback_(std::nullopt);
on_data_callback_ = nullptr;
}
return false;
Expand Down