Skip to content

[multi-packages] Migrate plus plugins to use flutter_lints#267

Merged
HakkyuKim merged 2 commits intoflutter-tizen:masterfrom
HakkyuKim:migrate-flutter-lints
Nov 10, 2021
Merged

[multi-packages] Migrate plus plugins to use flutter_lints#267
HakkyuKim merged 2 commits intoflutter-tizen:masterfrom
HakkyuKim:migrate-flutter-lints

Conversation

@HakkyuKim
Copy link
Copy Markdown
Contributor

@HakkyuKim HakkyuKim commented Nov 8, 2021 •
edited
Loading

@HakkyuKim HakkyuKim removed the needs-publishing The package should be published after merge label Nov 8, 2021
@HakkyuKim
Copy link
Copy Markdown
Contributor Author

HakkyuKim commented Nov 8, 2021

webview_flutter deprecated runJavascript in favor of runJavascriptForResult in 2.2.0 (https://github.com/flutter/plugins/blob/master/packages/webview_flutter/webview_flutter/CHANGELOG.md#220), this change affects google_maps_flutter_tizen and webview_flutter_tizen in dart analyze.

@bwikbs @seungsoo47
Could you update the package versions?

swift-kim
swift-kim approved these changes Nov 9, 2021
View reviewed changes
Comment thread analysis_options_plus.yaml Outdated
@bwikbs
Copy link
Copy Markdown
Member

bwikbs commented Nov 9, 2021

Could you update the package versions?

Sorry for the late reply, I'll update right away!

@HakkyuKim HakkyuKim changed the title [multi-packages] Migrate plug plugins to use flutter_lints [multi-packages] Migrate plus plugins to use flutter_lints Nov 9, 2021
@github-actions github-actions Bot added the needs-publishing The package should be published after merge label Nov 9, 2021
This was referenced Nov 9, 2021
Merged
Merged
@HakkyuKim HakkyuKim removed the needs-publishing The package should be published after merge label Nov 10, 2021
@HakkyuKim
Copy link
Copy Markdown
Contributor Author

HakkyuKim commented Nov 10, 2021

Could you update the package versions?

Sorry for the late reply, I'll update right away!

dart analyze now passes, thanks for the fix!

@HakkyuKim HakkyuKim merged commit 4a99a6c into flutter-tizen:master Nov 10, 2021
@HakkyuKim HakkyuKim deleted the migrate-flutter-lints branch December 21, 2021 04:34
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Mar 26, 2022
@HakkyuKim @bwikbs
[multi-packages] Migrate plus plugins to use flutter_lints (flutter-t…
0b8280d 
…izen#267)

* Migrate plug plugins to use flutter_lints

* Follow syntax of plus plugin repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WonyoungChoi WonyoungChoi WonyoungChoi approved these changes

@swift-kim swift-kim swift-kim approved these changes

Assignees

No one assigned

Labels

p: battery_plus p: connectivity_plus p: device_info_plus p: network_info_plus p: package_info_plus p: sensors_plus p: share_plus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate plus plugins to use flutter_lints

4 participants

@HakkyuKim @bwikbs @WonyoungChoi @swift-kim