Skip to content

fix: random errors preventing tests... #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmcdole merged 1 commit into from
Oct 1, 2025
Merged

fix: random errors preventing tests... #4859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions dashboard/lib/widgets/lattice.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ class LatticeScrollView extends StatelessWidget {
BuildContext context,
ViewportOffset horizontalOffset,
) => NotificationListener<OverscrollNotification>(
onNotification: (notification) =>
notification.metrics.axisDirection != AxisDirection.right &&
notification.metrics.axisDirection != AxisDirection.left,
onNotification:
(notification) =>
notification.metrics.axisDirection !=
AxisDirection.right &&
notification.metrics.axisDirection != AxisDirection.left,
child: Scrollbar(
thumbVisibility: true,
controller: verticalController,
Expand Down Expand Up @@ -576,9 +578,10 @@ class _RenderLatticeBody extends RenderBox {
super.attach(owner);
_horizontalOffset.addListener(_handleOffsetChange);
_verticalOffset.addListener(_handleOffsetChange);
_tap = TapGestureRecognizer(debugOwner: this)
..onTapDown = _handleTapDown
..onTapUp = _handleTapUp;
_tap =
TapGestureRecognizer(debugOwner: this)
..onTapDown = _handleTapDown
..onTapUp = _handleTapUp;
for (final child in _childrenByCoordinate.values) {
child.attach(owner);
}
Expand Down Expand Up @@ -809,7 +812,7 @@ class _RenderLatticeBody extends RenderBox {
void applyPaintTransform(RenderBox child, Matrix4 transform) {
final childParentData = child.parentData as _LatticeParentData;
final offset = _coordinateToOffset(childParentData.coordinate!)!;
transform.translate(offset.dx, offset.dy);
transform.translateByDouble(offset.dx, offset.dy, 0.0, 1.0);
}

@override
Expand Down
7 changes: 2 additions & 5 deletions dashboard/lib/widgets/user_sign_in.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class UserSignIn extends StatelessWidget {
if (authService.user != null) {
return PopupMenuButton<_SignInButtonAction>(
offset: const Offset(0, 50),
itemBuilder: (BuildContext context) =>
<PopupMenuEntry<_SignInButtonAction>>[
itemBuilder:
(BuildContext context) => <PopupMenuEntry<_SignInButtonAction>>[
const PopupMenuItem<_SignInButtonAction>(
value: _SignInButtonAction.logout,
child: Text('Log out'),
Expand Down Expand Up @@ -86,7 +86,4 @@ class FirebaseUserIdentity implements GoogleIdentity {
@override
// TODO: implement photoUrl
String? get photoUrl => user.photoURL;

@override
String? get serverAuthCode => '';
}