Skip to content

ordered presubmit builds processing#5104

Merged
auto-submit[bot] merged 11 commits into
flutter:mainfrom
ievdokdm:189029-order
Jul 14, 2026
Merged

ordered presubmit builds processing#5104
auto-submit[bot] merged 11 commits into
flutter:mainfrom
ievdokdm:189029-order

Conversation

@ievdokdm

Copy link
Copy Markdown
Contributor

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces ordered presubmit processing for LUCI build notifications by adding a new PresubmitOrderedSubscription endpoint, introducing an OrderingKeyTag to scheduled builds, and updating the PubSub service to support ordering keys. It also refactors the existing PresubmitLuciSubscription to inherit from a new base PresubmitSubscription class. The review feedback highlights an invalid Dart syntax error in the base class (override == .neutral ? .neutral : null) and suggests refactoring the common message parsing and validation logic into the base class's post method to eliminate code duplication, along with cleaning up unused imports.

Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart Outdated
Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart
Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart
Comment thread app_dart/lib/src/request_handlers/presubmit_luci_subscription.dart Outdated
Comment thread app_dart/lib/src/request_handlers/presubmit_ordered_subscription.dart Outdated
Comment thread app_dart/lib/src/request_handlers/presubmit_ordered_subscription.dart Outdated
@ievdokdm

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors presubmit build status processing by extracting shared logic from PresubmitLuciSubscription into a new base class PresubmitSubscription, and introduces PresubmitOrderedSubscription to support sequential processing of LUCI notifications via PubSub ordering keys. It also adds configuration flags to control this feature and updates LuciBuildService to attach ordering keys to scheduled builds. The review feedback highlights three potential runtime issues in the newly created PresubmitSubscription class: a potential decompression crash if buildLargeFields is empty, a potential null pointer exception from force-unwrapping userData.checkRunId, and a potential type cast error when parsing presubmit_max_attempts.

Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart Outdated
Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart
Comment thread app_dart/lib/src/request_handlers/presubmit_subscription.dart Outdated
@ievdokdm ievdokdm requested a review from jtmcdole July 13, 2026 18:20
@ievdokdm ievdokdm requested a review from eyebrowsoffire July 13, 2026 22:53
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 14, 2026
@auto-submit auto-submit Bot merged commit b2ef634 into flutter:main Jul 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configure pub/sub to process messages sequentially within check runs

2 participants