Skip to content

Remove semantics_tester import from material_button_test.dart #184807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jun 2, 2026
Merged

Remove semantics_tester import from material_button_test.dart #184807

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2915c2
Remove semantics_tester import from material_button_test.dart
Sanaullah49 Apr 9, 2026
3459e6b
Address review feedback on MaterialButton semantics test
Sanaullah49 Apr 9, 2026
71eb0df
Address review feedback: addTearDown, restore transform check, consis…
Sanaullah49 May 5, 2026
c4bb886
Address chunhtai feedback: remove unneeded ensureSemantics
Sanaullah49 May 13, 2026
589399c
Fix undefined TestSemantics by inlining 800x600 screen constants
Sanaullah49 May 15, 2026
31b36cf
Fix material button semantics checks
Sanaullah49 May 21, 2026
f10c498
Merge branch 'master' into chore/182636-material-button-semantics
dkwingsmt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 32 additions & 50 deletions packages/flutter/test/material/material_button_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';

import 'semantics_tester.dart';

void main() {
setUp(() {
debugResetSemanticsIdCounter();
Expand Down Expand Up @@ -637,15 +635,13 @@ void main() {
testWidgets(
'Disabled MaterialButton has same semantic size as enabled and exposes disabled semantics',
(WidgetTester tester) async {
final semantics = SemanticsTester(tester);

const expectedButtonSize = Rect.fromLTRB(0.0, 0.0, 116.0, 48.0);
// Button is in center of screen
final expectedButtonTransform = Matrix4.identity()

@chunhtai chunhtai May 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the check for transform?

I think we can directly compare SemanticsNode.transform

@Sanaullah49 Sanaullah49 May 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept — expect(enabledSemantics.transform, expectedButtonTransform) and the same for disabledSemantics are now in the test (lines 678 and 708). The expectedButtonTransform constant is preserved.

..translate(
TestSemantics.fullScreen.width / 2 - expectedButtonSize.width / 2,
TestSemantics.fullScreen.height / 2 - expectedButtonSize.height / 2,
);
const expectedButtonSize = Size(116.0, 48.0);
// Button is in center of the 800x600 test screen.
final expectedButtonTransform = Matrix4.diagonal3Values(
tester.view.devicePixelRatio,
tester.view.devicePixelRatio,
1.0,
)..translate(400.0 - expectedButtonSize.width / 2, 300.0 - expectedButtonSize.height / 2);

// enabled button
await tester.pumpWidget(
Expand All @@ -665,28 +661,21 @@ void main() {
),
);

final SemanticsNode enabledSemantics = tester.getSemantics(find.byType(MaterialButton));
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
id: 1,
rect: expectedButtonSize,
transform: expectedButtonTransform,
label: 'Button',
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isEnabled,
SemanticsFlag.isFocusable,
],
),
],
),
enabledSemantics,
matchesSemantics(
label: 'Button',
hasTapAction: true,
hasFocusAction: true,
hasEnabledState: true,
isButton: true,
isEnabled: true,
isFocusable: true,
size: expectedButtonSize,
),
);
expect(enabledSemantics.transform, expectedButtonTransform);

// disabled button
await tester.pumpWidget(
Expand All @@ -704,29 +693,22 @@ void main() {
),
);

final SemanticsNode disabledSemantics = tester.getSemantics(find.byType(MaterialButton));
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
id: 1,
rect: expectedButtonSize,
transform: expectedButtonTransform,
label: 'Button',
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[SemanticsAction.focus],
),
],
),
disabledSemantics,
matchesSemantics(
label: 'Button',
hasFocusAction: true,
hasEnabledState: true,
isButton: true,
isFocusable: true,
size: expectedButtonSize,
),
Comment thread
chunhtai marked this conversation as resolved.
);

semantics.dispose();
expect(disabledSemantics.transform, expectedButtonTransform);
final SemanticsData semanticsData = disabledSemantics.getSemanticsData();
expect(semanticsData.hasFlag(SemanticsFlag.isEnabled), isFalse);
expect(semanticsData.hasAction(SemanticsAction.tap), isFalse);
},
);

Expand Down
Loading