Skip to content

Use null-aware elements in dev/devicelab/lib/integration_tests.dart#187852

Merged
auto-submit[bot] merged 11 commits into
flutter:masterfrom
lukluca:fix/172188-null-aware-integration-tests
Jul 1, 2026
Merged

Use null-aware elements in dev/devicelab/lib/integration_tests.dart#187852
auto-submit[bot] merged 11 commits into
flutter:masterfrom
lukluca:fix/172188-null-aware-integration-tests

Conversation

@lukluca

@lukluca lukluca commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Adopts null-aware element syntax (?x) in dev/devicelab/lib/integration_tests.dart, replacing 2 instances of the verbose if (x != null) x! pattern in the integration_tests file.

Part of #172188

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the env map in dev/devicelab/lib/tasks/integration_tests.dart by using the null-aware spread operator for environment and changing the assignment of FLUTTER_ADB_PATH. No review comments were provided, and there is no feedback to report.

@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Jun 15, 2026
@jmagman jmagman added platform-android Android applications specifically team-android Owned by Android platform team labels Jun 15, 2026
@jmagman

jmagman commented Jun 15, 2026

Copy link
Copy Markdown
Member

I added platform-android since integration_tests doesn't have a clear owner and this is adb related.

@github-actions github-actions Bot removed platform-android Android applications specifically team-android Owned by Android platform team CICD Run CI/CD labels Jun 15, 2026
@AbdeMohlbi AbdeMohlbi added platform-android Android applications specifically CICD Run CI/CD team-android Owned by Android platform team labels Jun 15, 2026
@AbdeMohlbi

Copy link
Copy Markdown
Member

Please don't merge with head again, let the tests run

@reidbaker

reidbaker commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Because of the volume of PRs we receive, we require that new contributors use our checklist to guide them through critical steps in creating a Flutter PR. This PR's description is missing that checklist, so it is being marked as a Draft.

Please edit the PR description to add the checklist, then ensure that you have completed all of the steps. Once you've done that, please mark the PR as ready for review.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@reidbaker reidbaker marked this pull request as draft June 16, 2026 21:37
@github-actions github-actions Bot added CICD Run CI/CD and removed CICD Run CI/CD platform-android Android applications specifically team-android Owned by Android platform team labels Jun 22, 2026
@lukluca lukluca marked this pull request as ready for review June 22, 2026 18:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the initialization of the env map in dev/devicelab/lib/tasks/integration_tests.dart by using the null-aware spread operator ...? for the environment variable and modifying the assignment of 'FLUTTER_ADB_PATH'. There are no review comments, so I have no feedback to provide.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 1, 2026
@github-actions github-actions Bot removed platform-android Android applications specifically team-android Owned by Android platform team labels Jul 1, 2026
@reidbaker reidbaker added platform-android Android applications specifically team-android Owned by Android platform team CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jul 1, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jul 1, 2026
Merged via the queue into flutter:master with commit d100ca3 Jul 1, 2026
187 of 188 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2026
This was referenced Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants