[flutter_tools] Watch transitive #include headers for FragmentProgram hot reload#187945
Conversation
… hot reload Pass --depfile to impellerc and track dependencies in DevelopmentShaderCompiler to trigger hot reload when transitive includes are modified. Fixes flutter#186343
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces tracking of transitive shader dependencies in DevelopmentShaderCompiler to determine if shaders need recompilation during DevFS syncs. It parses depfiles generated by impellerc and exposes areDependenciesModified to check for modified dependencies. Feedback highlights a potential FileSystemException when calling dep.statSync() in areDependenciesModified, which could crash the sync process and should be wrapped in a try-catch block.
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
Wrap dependency existence and stat checks in a try-catch block in areDependenciesModified to prevent crashing the DevFS sync process if a FileSystemException occurs.
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/187945, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
bkonyi
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/187945, Failed to enqueue flutter/flutter/187945 with HTTP 400: No merge queue found for branch 'main'. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
autosubmit label was removed for flutter/flutter/187945, because Pull request flutter/flutter/187945 is not in a mergeable state. |
auto-submit
Bot
removed
the
autosubmit
# Conflicts: # packages/flutter_tools/lib/src/devfs.dart
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
flutter-dashboard
Bot
removed
the
autosubmit
…r-187945 # Conflicts: # packages/flutter_tools/lib/src/build_system/tools/shader_compiler.dart # packages/flutter_tools/test/general.shard/build_system/targets/shader_compiler_test.dart
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
Fixes #186343
This PR enables hot reloading of shaders when their transitive
#includedependencies are modified.Changes:
--depfiletoimpellercto generate dependency files.DevelopmentShaderCompilerusingDepfileService.