Moves test ownership validation to flutter/flutter#188655
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the Linux test_ownership target from .ci.yaml and introduces a new Dart test, test_ownership_validation_test.dart, to validate that all CI targets in .ci.yaml have a defined owner in TESTOWNERS. Feedback on the changes highlights a compile-time error caused by attempting to instantiate the abstract class YamlMap directly, and suggests using RegExp(r'\s+') instead of split(' ') to robustly handle multiple consecutive spaces when parsing target names and owners.
This reverts commit 863548a.
Member
Author
jtmcdole
approved these changes
Jun 29, 2026
Member
|
Unpopular opinion, but I like: final isShard = switch ((recipe, tags?.contains('shard'), properties)) {
('flutter/flutter_drone', _, _) => true,
(_, true, _) => true,
(_, _, final p) when p['shard'] != null => true,
_ => false,
}; |
Member
Author
|
Oh yea, that's nice. I don't usually create new structures in order to send them to a |
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

issue: #188640
This follows the pattern from #161249
This duplicates the logic of https://github.com/flutter/cocoon/blob/main/app_dart/bin/validate_task_ownership.dart
Note that the TESTOWNERS file format seems straightforward but it is actually weird where things that look like comments have semantic meaning.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.