Skip to content

Update GEMINI instructions for catalog items, add implementation descriptions.#31

Merged
gspencergoog merged 2 commits into
flutter:mainfrom
gspencergoog:add_docs
Aug 1, 2025
Merged

Update GEMINI instructions for catalog items, add implementation descriptions.#31
gspencergoog merged 2 commits into
flutter:mainfrom
gspencergoog:add_docs

Conversation

@gspencergoog

Copy link
Copy Markdown
Collaborator

Description

Just added a hint to use extension types for the data in catalog items, and added some files that outline the implementation of the travel app and the SDK package.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new implementation documents, one for the travel app example and one for the flutter_genui package. The documentation provides a good overview of the architecture and implementation details. My feedback includes a suggestion to update a link to point to the more detailed implementation file and a recommendation to standardize the list formatting in the markdown for better readability and consistency.

Comment thread examples/travel_app/IMPLEMENTATION.md Outdated
Comment thread pkgs/flutter_genui/IMPLEMENTATION.md Outdated
@gspencergoog gspencergoog changed the title Update GEMINI instructions for catalog items Update GEMINI instructions for catalog items, add implementation descriptions. Jul 31, 2025
@gspencergoog gspencergoog requested a review from polina-c July 31, 2025 23:41

@jacobsimionato jacobsimionato left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Comment thread .gemini/GEMINI.md Outdated
@@ -3,26 +3,28 @@
A CatalogItem is an object which represents a widget that can be instantiated by an LLM. It centralizes the builder function for the widget along with the data schema and name.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may I ask you to add README.md to the folder .gemini with summary what it is for and link to documentation?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem.

Update GEMINI instructions for catalog items
Add README.md for .gemini directory.
@gspencergoog gspencergoog merged commit 5ba0ba5 into flutter:main Aug 1, 2025
4 checks passed
@gspencergoog gspencergoog deleted the add_docs branch August 1, 2025 23:20
sethgw added a commit to layups-ai/genui that referenced this pull request Jul 8, 2026
- Bump protocol version to v1.0 in message envelopes and capabilities
- Rename createSurface 'theme' to 'surfaceProperties'; support inline
  'components' and 'dataModel' for single-message UI instantiation
- Add CallFunctionMessage/ActionResponseMessage (server-to-client) and
  A2uiFunctionResponse (client-to-server) with actionId correlation
- Add callableFrom execution boundaries with INVALID_FUNCTION_CALL
  rejection for remote calls to clientOnly/unregistered functions
- Serialize catalog functions as a map keyed by name with static
  returnType/callableFrom metadata; move surfaceProperties under $defs
- Remove wire-level returnType from FunctionCall payloads
- Serialize explicit null in updateDataModel for key deletion
- Add @index system function (with offset) scoped to template loops
- Enforce UAX flutter#31 identifier rules for catalog entity names
- Add optional catalog 'instructions' (replaces external rules text)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants