Skip to content

[google_maps_flutter] Add AdvancedMarker to exports#11194

Open
yuruyuri16 wants to merge 2 commits intoflutter:mainfrom
yuruyuri16:patch-1
Open

[google_maps_flutter] Add AdvancedMarker to exports#11194
yuruyuri16 wants to merge 2 commits intoflutter:mainfrom
yuruyuri16:patch-1

Conversation

@yuruyuri16
Copy link

@yuruyuri16 yuruyuri16 commented Mar 6, 2026

Export AdvancedMarker in google_maps_flutter.
Otherwise, users would need to import google_maps_flutter_platform_interface to be able to use it.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Export AdvancedMarker in Google Maps Flutter package.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla
Copy link

google-cla bot commented Mar 6, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exports the AdvancedMarker class from the google_maps_flutter package by adding it to the export list in google_maps_flutter.dart. This makes the class available to users of the package without a separate import.

Please note that the repository's contribution guidelines require pull request titles to be prefixed with the package name in square brackets (e.g., [google_maps_flutter]). Please update the title accordingly.

@yuruyuri16 yuruyuri16 changed the title Add AdvancedMarker to exports in google_maps_flutter.dart [google_maps_flutter] Add AdvancedMarker to exports in google_maps_flutter.dart Mar 6, 2026
@yuruyuri16 yuruyuri16 changed the title [google_maps_flutter] Add AdvancedMarker to exports in google_maps_flutter.dart [google_maps_flutter] Add AdvancedMarker to exports Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant