Skip to content

[rfw] Opt out of icon tree shaking #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcharkes merged 1 commit into from
Mar 11, 2026
Merged

[rfw] Opt out of icon tree shaking #11216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/rfw/lib/src/flutter/argument_decoders.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,12 @@ class ArgumentDecoders {
return null;
}
return IconData(
// RFW does _not_ support tree-shaking icons. Explicitly suppress the lint
// that warns about non-constant arguments which will cause the flutter
// icon tree shaker to bail out of tree-shaking icons.
// ignore: non_const_argument_for_const_parameter
icon,
// ignore: non_const_argument_for_const_parameter
fontFamily: source.v<String>([...key, 'fontFamily']),
matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false,

@gemini-code-assist gemini-code-assist Bot Mar 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It seems you've missed adding an ignore for the matchTextDirection parameter. According to the Flutter PR you linked, matchTextDirection is also annotated with @mustBeConst. Since the value passed here is not a compile-time constant, it will also trigger the non_const_argument_for_const_parameter lint and should be ignored.

Suggested change
matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false,
// ignore: non_const_argument_for_const_parameter
matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false,

@dcharkes dcharkes Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mr AI bot, you are talking BS:

image

);
Expand Down
Loading