[video_player_avfoundation] Implement preventsDisplaySleepDuringVideoPlayback by shrabanti722 · Pull Request #11547 · flutter/packages

shrabanti722 · 2026-04-21T11:47:46Z

Description

Implements the setPreventsDisplaySleepDuringVideoPlayback platform interface method using AVPlayer.preventsDisplaySleepDuringVideoPlayback on iOS and macOS.

AVFoundation implementation breakout PR for #11225.

Dependencies

Depends on the video_player_platform_interface 6.7.0 breakout PR. CI will fail until that PR lands and the new interface version is published. Keeping this PR in draft until then.

Changes

Implements setPreventsDisplaySleepDuringVideoPlayback in FVPVideoPlayer.m and wires it through the Dart platform implementation.
Adds the Pigeon method definition and regenerates messages (includes a pigeon v26.1.7 → v26.2.3 bump carried over from the parent PR).
Bumps video_player_avfoundation to 2.10.0 and updates the video_player_platform_interface constraint to ^6.7.0.
Updates CHANGELOG.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request implements the setPreventsDisplaySleepDuringVideoPlayback feature for the AVFoundation video player, enabling control over display sleep during playback. The changes include updates to Pigeon message definitions, the Dart platform implementation, and the native Objective-C code. Feedback indicates that the implementation lacks required unit or integration tests as specified in the repository style guide.

…Playback Implements the platform interface method `setPreventsDisplaySleepDuringVideoPlayback` using `AVPlayer.preventsDisplaySleepDuringVideoPlayback` on iOS and macOS. AVFoundation implementation breakout PR for flutter#11225. Depends on the platform interface breakout PR (6.7.0). Made-with: Cursor

gemini-code-assist

Code Review

This pull request implements setPreventsDisplaySleepDuringVideoPlayback for the AVFoundation video player implementation, allowing control over display sleep during video playback. The changes include Pigeon-generated message updates, Dart and Objective-C platform code additions, and corresponding unit tests. Feedback on the changes suggests removing a redundant @available check in FVPVideoPlayer.m since the package's minimum supported versions are already higher than the check specifies.

gemini-code-assist · 2026-06-27T07:49:16Z

+- (void)setPreventsDisplaySleepDuringVideoPlayback:(BOOL)preventsDisplaySleepDuringVideoPlayback error:(FlutterError *_Nullable *_Nonnull)error {
+  if (@available(iOS 12.0, macOS 10.14, *)) {
+    self.player.preventsDisplaySleepDuringVideoPlayback = preventsDisplaySleepDuringVideoPlayback;
+  }
+}


Since the minimum supported versions for this package are iOS 13.0 and macOS 10.15 (as of version 2.8.5), the @available(iOS 12.0, macOS 10.14, *) check is redundant. We can safely remove it to simplify the code.

- (void)setPreventsDisplaySleepDuringVideoPlayback:(BOOL)preventsDisplaySleepDuringVideoPlayback error:(FlutterError *_Nullable *_Nonnull)error { self.player.preventsDisplaySleepDuringVideoPlayback = preventsDisplaySleepDuringVideoPlayback; }

…tion Resolves conflicts caused by the avfoundation Pigeon and source-directory restructure on main: - Drops stale pigeons/messages.dart, lib/src/messages.g.dart, and the old messages.g.h (the file split into instance/plugin pigeons under video_player_avfoundation_objc/). - Re-applies setPreventsDisplaySleepDuringVideoPlayback to pigeons/video_player_instance_messages.dart. - Accepts upstream copies of regenerated files (VideoPlayerInstanceMessages.g.m, avfoundation_video_player_test.mocks.dart) — will be regenerated next. - Bumps version 2.10.0 -> 2.11.0 and platform_interface dep ^6.7.0 -> ^6.8.0.

- Regenerates VideoPlayerInstanceMessages.g.{h,m,dart} so the new setPreventsDisplaySleepDuringVideoPlayback method is plumbed through. - Regenerates avfoundation_video_player_test.mocks.dart to include the new method's mock entry. - clang-formats the regenerated ObjC files. - dart format --page-width 100 across lib/, test/, pigeons/. - Adds the new pigeon method to video_player_instance_messages.dart.

shrabanti722 · 2026-06-27T08:17:18Z

@stuartmorgan-g @tarrinneal this is the AVFoundation child PR for the screen auto-lock change.

hellohuanlin

Seems to be a straight forward change, but it's missing unit tests on native side.

stuartmorgan-g · 2026-06-30T17:15:57Z

@hellohuanlin In the future, please try to check for missing tests when reviewing the combo PR. Part of the goal of getting all necessary approvals on the combo PR before splitting out the sub PRs is to have the sub PRs all land very quickly so that we don't end up in a limbo where features are partially landed for extended periods of time.

stuartmorgan-g · 2026-06-30T17:16:27Z


+- (void)setPreventsDisplaySleepDuringVideoPlayback:(BOOL)preventsDisplaySleepDuringVideoPlayback
+                                             error:(FlutterError *_Nullable *_Nonnull)error {
+  if (@available(iOS 12.0, macOS 10.14, *)) {


Why are you doing runtime checks for OS versions that are lower than our minimum compilation targets? This condition can never be false.

@available

- Remove the redundant @available(iOS 12.0, macOS 10.14, *) check in setPreventsDisplaySleepDuringVideoPlayback; the package minimums are iOS 13 / macOS 10.15, so the condition can never be false. - Add a native Swift unit test verifying the setter updates the underlying AVPlayer in both directions.

stuartmorgan-g · 2026-07-01T18:16:08Z

@shrabanti722 It looks like you either didn't run the repo format command, or you have a different version of clang-format than our CI; either way you'll need to adjust the formatting per the diff in this failure.

shrabanti722 · 2026-07-01T18:28:56Z

@shrabanti722 It looks like you either didn't run the repo format command, or you have a different version of clang-format than our CI; either way you'll need to adjust the formatting per the diff in this failure.

Yeah @stuartmorgan-g I actually came on a vacation and don’t have my Mac with me, so couldn’t run it locally, I used a windows laptop for this since it was getting delayed. But looks like I will be able to fix it only after I come back :( which will be 5 - 6 days. Sorry for that.

shrabanti722 marked this pull request as draft April 21, 2026 11:47

github-actions Bot added platform-ios platform-macos p: video_player labels Apr 21, 2026

gemini-code-assist Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart

shrabanti722 force-pushed the video-player-prevents-display-sleep-avfoundation branch from 431a14a to b53cddc Compare April 21, 2026 12:03

shrabanti722 mentioned this pull request Apr 21, 2026

[video_player] Implement screen auto-lock control for video playback #11225

Open

11 tasks

shrabanti722 marked this pull request as ready for review June 27, 2026 07:48

gemini-code-assist Bot reviewed Jun 27, 2026

View reviewed changes

shrabanti722 added 2 commits June 27, 2026 13:34

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jun 29, 2026

stuartmorgan-g requested review from LouiseHsu and hellohuanlin June 29, 2026 14:29

hellohuanlin reviewed Jun 29, 2026

View reviewed changes

stuartmorgan-g reviewed Jun 30, 2026

View reviewed changes

shrabanti722 requested review from hellohuanlin and stuartmorgan-g July 1, 2026 15:40

stuartmorgan-g approved these changes Jul 1, 2026

View reviewed changes

stuartmorgan-g added the CICD Run CI/CD label Jul 1, 2026

Apply formatting manually

928d9ca

flutter-dashboard Bot removed the CICD Run CI/CD label Jul 1, 2026

stuartmorgan-g added the CICD Run CI/CD label Jul 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[video_player_avfoundation] Implement preventsDisplaySleepDuringVideoPlayback#11547

[video_player_avfoundation] Implement preventsDisplaySleepDuringVideoPlayback#11547
shrabanti722 wants to merge 5 commits into
flutter:mainfrom
shrabanti722:video-player-prevents-display-sleep-avfoundation

shrabanti722 commented Apr 21, 2026

Uh oh!

flutter-dashboard Bot commented Apr 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jun 27, 2026

Uh oh!

shrabanti722 commented Jun 27, 2026

Uh oh!

hellohuanlin left a comment

Uh oh!

stuartmorgan-g commented Jun 30, 2026

Uh oh!

stuartmorgan-g Jun 30, 2026

Uh oh!

shrabanti722 Jul 1, 2026

Uh oh!

stuartmorgan-g commented Jul 1, 2026

Uh oh!

shrabanti722 commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shrabanti722 commented Apr 21, 2026

Description

Dependencies

Changes

Related

Uh oh!

flutter-dashboard Bot commented Apr 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

shrabanti722 commented Jun 27, 2026

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 30, 2026

Uh oh!

stuartmorgan-g Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

shrabanti722 Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jul 1, 2026

Uh oh!

shrabanti722 commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants