Skip to content

[path_provider] Create temp dir in tests if needed #11841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jun 4, 2026
Merged

[path_provider] Create temp dir in tests if needed #11841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/path_provider/path_provider/example/integration_test/path_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ void main() {

testWidgets('getTemporaryDirectory', (WidgetTester tester) async {
final Directory result = await getTemporaryDirectory();
_verifySampleFile(result, 'temporaryDirectory');
// getTemporaryDirectory does not guarantee that the returned directory exists.
_verifySampleFile(result, 'temporaryDirectory', createDirectory: true);
});

testWidgets('getApplicationDocumentsDirectory', (WidgetTester tester) async {
Expand Down Expand Up @@ -109,7 +110,9 @@ void main() {

/// Verify a file called [name] in [directory] by recreating it with test
/// contents when necessary.
void _verifySampleFile(Directory? directory, String name) {
///
/// If [createDirectory] is true, the directory will be created if missing.
void _verifySampleFile(Directory? directory, String name, {bool createDirectory = false}) {
expect(directory, isNotNull);
if (directory == null) {
return;
Expand All @@ -121,6 +124,10 @@ void _verifySampleFile(Directory? directory, String name) {
expect(file.existsSync(), isFalse);
}

if (createDirectory && !directory.existsSync()) {
directory.createSync(recursive: true);
}

file.writeAsStringSync('Hello world!');
expect(file.readAsStringSync(), 'Hello world!');
// This check intentionally avoids using Directory.listSync on Android due to
Expand Down
9 changes: 7 additions & 2 deletions ...s/path_provider/path_provider_foundation/example/integration_test/path_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ void main() {
testWidgets('getTemporaryDirectory', (WidgetTester tester) async {
final PathProviderPlatform provider = PathProviderPlatform.instance;
final String? result = await provider.getTemporaryPath();
_verifySampleFile(result, 'temporaryDirectory');
// getTemporaryPath does not guarantee that the returned directory exists.
_verifySampleFile(result, 'temporaryDirectory', createDirectory: true);
});

testWidgets('getApplicationDocumentsDirectory', (WidgetTester tester) async {
Expand Down Expand Up @@ -374,7 +375,7 @@ NSArray _arrayWithString(String s) {
/// contents when necessary.
///
/// If [createDirectory] is true, the directory will be created if missing.
void _verifySampleFile(String? directoryPath, String name) {
void _verifySampleFile(String? directoryPath, String name, {bool createDirectory = false}) {
expect(directoryPath, isNotNull);
if (directoryPath == null) {
return;
Expand All @@ -387,6 +388,10 @@ void _verifySampleFile(String? directoryPath, String name) {
expect(file.existsSync(), isFalse);
}

if (createDirectory && !directory.existsSync()) {
directory.createSync(recursive: true);
}

file.writeAsStringSync('Hello world!');
expect(file.readAsStringSync(), 'Hello world!');
expect(directory.listSync(), isNotEmpty);
Expand Down
Loading