[camera_android_camerax] Fix setFocusMode(auto) crash when there is no auto-focus point

[motucraft]

Adds the missing isEmpty guard to the FocusMode.auto branch of AndroidCameraCameraX.setFocusMode, which read meteringPointsAf.first unconditionally and threw StateError: Bad state: No element when the current focus-and-metering action had no auto-focus point.

The FocusMode.locked branch already guards this; the auto branch did not.

Fixes flutter/flutter#187782

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request fixes a StateError in setFocusMode(FocusMode.auto) when the current focus and metering action has no auto-focus points. The implementation safely retrieves the list of auto-focus points and checks if it is empty before accessing the first element. A unit test has been added to verify this behavior, and the package version has been bumped to 0.7.2+2. There are no review comments to address.

[camsim99]

LGTM! Thank you for the extremely well-written bug and a straightforward fix :)

[reidbaker]

This does not make sense to me. let me rewrite the turnary to an if statement to make it a bit easier to read.

if(_defaultFocusPointLocked || possibleCurrentAfPoints.isEmpty) {
   return null
} else {
   return possibleCurrentAfPoints.first;
}

I believe this code will throw a state error if _defaultFocusPointLocked == true and possibleCurrentAfPoints is an empty list. Which looks like the error you are claiming to fix.

Did I make a mistake or is there something I am misunderstanding?

[motucraft]

@reidbaker

Thanks for the review. I think this should not throw. With this condition, possibleCurrentAfPoints.first is only evaluated when _defaultFocusPointLocked is false and possibleCurrentAfPoints is not empty. If _defaultFocusPointLocked is true or the list is empty, the expression returns null.

Please let me know if I’m missing something.

[reidbaker]

facepalm, yes sorry reviewing code tired will do that. Thank you for responding with grace.

[motucraft]

This PR became conflicted while waiting after approval. I’ve merged the latest main and resolved the conflicts.

[stuartmorgan-g]

It looks like autosubmit wasn't added with the final approval for some reason.