[local_auth] Clarify getAvailableBiometrics documentation regarding iOS permissions#11901
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the getAvailableBiometrics method in LocalAuthentication to clarify that it returns only the biometrics currently available for the app's use, noting that some enrolled biometrics may be excluded due to missing user permissions. There are no review comments, and no additional feedback is provided.
anirudhsharma392
changed the title
|
Thanks for the contribution!
The email associated with the commit does not correspond to a signed CLA. If you intended to use a different email address for your contribution, you will need to adjust your
Could you quote the part of the linked instructions that you believe say that documentation changes are exempt from versioning and changelog? |
|
@stuartmorgan-g My apologies, I misread the guidelines here. Since this is a doc comment on a public API ( |
|
@anirudhsharma392 I'm not sure I understand the question. Is something about the FAQ in that screenshot unclear? |
8bed63e to
9941bac
Compare
|
@stuartmorgan-g It was my bad, Never mind, I have now signed the CLA and pushed the updated commit containing the version bump and CHANGELOG. |
|
Hi @stuartmorgan-g, I’ve addressed the issues. Could you take another look when you get a chance? Thanks! |
bparrishMines
added
the
autosubmit
…r#189194) flutter/packages@52d84d6...20928d5 2026-07-09 44525804+sailendrabathi@users.noreply.github.com [video_player_android] Implement backBufferDurationMs in ExoPlayer (flutter/packages#12124) 2026-07-09 bolling.ludwig@gmail.com [camera_platform_interface] Make setJpegImageQuality default a no-op (flutter/packages#12123) 2026-07-09 36081049+anirudhsharma392@users.noreply.github.com [local_auth] Clarify getAvailableBiometrics documentation regarding iOS permissions (flutter/packages#11901) 2026-07-09 stuartmorgan@google.com [ci] Add a third web Dart unit test shard (2/2) (flutter/packages#12150) 2026-07-08 stuartmorgan@google.com [ci] Add a third web Dart unit test shard (1/2) (flutter/packages#12138) 2026-07-08 43054281+camsim99@users.noreply.github.com Add pre-commit hook to verify static analysis passes & format is correct (flutter/packages#11941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Clarifies the
getAvailableBiometricsdocstring to explain that it returns biometrics available for the app to use, which may not include all enrolled biometrics (e.g., if iOS permission has not been granted).Fixes: flutter/flutter#187512
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Exceptions
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2