[video_player_platform_interface] Improve seek performance on Android#11932
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces backBufferDurationMs to VideoPlayerOptions to configure ExoPlayer's back buffer duration on Android, and adds videoPlayerOptions to VideoCreationOptions. Feedback suggests updating the assertion to allow a value of 0 (enabling developers to disable back buffering) and correcting the markdown spacing in the documentation comment for proper bold rendering.
c686c5b to
3360f98
Compare
mboetger
left a comment
mboetger
left a comment
There was a problem hiding this comment.
Holding on for ecosystem review
stuartmorgan-g
added
the
federated: partial_changes
3360f98 to
7811816
Compare
|
@mboetger, I updated the PR after approval from ecosystem reviewer. Comment link for reference: #11810 (review) |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| final VideoViewType viewType; | ||
|
|
||
| /// Additional configuration options for the video player. | ||
| final VideoPlayerOptions? videoPlayerOptions; |
There was a problem hiding this comment.
Composing the two different options classes seems potentially confusing, but it doesn't look like the API surface ever clearly distinguished these conceptually. Since VideoCreationOptions isn't exposed to app-level clients it's probably not a big deal.
@tarrinneal As part of revisiting the video_player API surface later, it would be good to better distinguish what classes are for what steps of the process (e.g., global vs player-level options, which may have been the original intent here?), and we should also fix the fact that some of these classes are being directly re-exported from the app-facing package, which we should stop doing.
stuartmorgan-g
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/11932, because This PR has not met approval requirements for merging. Changes were requested by {mboetger}, please make the needed changes and resubmit this PR.
|
Requested change was just to hold for ecosystem review, which has now happened.
stuartmorgan-g
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/11932, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
autosubmit
…#189007) flutter/packages@2fbe873...fc00ceb 2026-07-06 44525804+sailendrabathi@users.noreply.github.com [video_player_platform_interface] Improve seek performance on Android (flutter/packages#11932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…flutter#11932) Adds `backBufferDurationMs` to `video_player_platform_interface` This PR has only the platform interface package changes from the main PR: flutter#11810. Following PR split as per [Changing federated plugins](https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins) ## Pre-Review Checklist
4 participants
Adds
backBufferDurationMstovideo_player_platform_interfaceThis PR has only the platform interface package changes from the main PR: #11810.
Following PR split as per Changing federated plugins
Pre-Review Checklist
[shared_preferences]///).