Skip to content

[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder #11960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Jun 30, 2026
Merged

[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder #11960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6205c1
[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder
Anantha-Eswar Jun 23, 2026
1a59253
Bump version to 0.7.3 and update CHANGELOG
Anantha-Eswar Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.7.3

* Fixes `videoBitrate` configuration being ignored during video recording.

## 0.7.2+1

* Migrates to Built-in Kotlin to support AGP 9.
Expand Down
5 changes: 4 additions & 1 deletion packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,10 @@ class AndroidCameraCameraX extends CameraPlatform {
);

// Configure VideoCapture and Recorder instances.
recorder = Recorder(qualitySelector: presetQualitySelector);
recorder = Recorder(
qualitySelector: presetQualitySelector,
targetVideoEncodingBitRate: mediaSettings?.videoBitrate,
);
videoCapture = VideoCapture.withOutput(videoOutput: recorder!, targetFpsRange: _targetFpsRange);

// Retrieve info required for correcting the rotation of the camera preview
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.7.2+1
version: 0.7.3

environment:
sdk: ^3.12.0
Expand Down
3 changes: 3 additions & 0 deletions packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,10 @@ void main() {
}) {
return mockImageCapture;
};
int? recorderTargetVideoEncodingBitRate;
PigeonOverrides.recorder_new =
({int? aspectRatio, int? targetVideoEncodingBitRate, QualitySelector? qualitySelector}) {
recorderTargetVideoEncodingBitRate = targetVideoEncodingBitRate;
return mockRecorder;
};
PigeonOverrides.videoCapture_withOutput =
Expand Down Expand Up @@ -658,6 +660,7 @@ void main() {

// Verify the camera's Recorder and VideoCapture instances are instantiated properly.
expect(camera.recorder, equals(mockRecorder));
expect(recorderTargetVideoEncodingBitRate, equals(200000));
expect(camera.videoCapture, equals(mockVideoCapture));

// Verify the camera's Preview instance has its surface provider set.
Expand Down