Skip to content

[material_ui] Enable filter_chip_test#12013

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
elliette:pr184297/filter-chip-test
Jun 26, 2026
Merged

[material_ui] Enable filter_chip_test#12013
auto-submit[bot] merged 1 commit into
flutter:mainfrom
elliette:pr184297/filter-chip-test

Conversation

@elliette

@elliette elliette commented Jun 25, 2026

Copy link
Copy Markdown
Member

Port over filter_chip_test from flutter/flutter#184279

Work towards flutter/flutter#182636 and flutter/flutter#188395

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes skip annotations from several test files, extracts the tooltip finder helper into a shared finders.dart file, and adds a FeedbackTester helper. The reviewer recommends using a null-aware operator instead of a null assertion operator on widget.richMessage in finders.dart to avoid potential runtime exceptions.

Comment thread packages/material_ui/test/finders.dart
@elliette elliette force-pushed the pr184297/filter-chip-test branch from e1d7221 to a6f0e90 Compare June 26, 2026 18:19
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
@elliette elliette added the CICD Run CI/CD label Jun 26, 2026

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026
@auto-submit auto-submit Bot merged commit f8a1f6f into flutter:main Jun 26, 2026
88 checks passed
Rushikesh1414 pushed a commit to Rushikesh1414/flutter that referenced this pull request Jun 29, 2026
…er#188728)

flutter/packages@c1f7d92...656ccaa

2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `icon_button_test` (flutter/packages#12015)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `list_tile_test` (flutter/packages#12017)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `calendar_date_picker_test` (flutter/packages#12006)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `filter_chip_test` (flutter/packages#12013)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `ink_well_test` (flutter/packages#12016)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `radio_list_tile_test` (flutter/packages#12019)
2026-06-26 21270878+elliette@users.noreply.github.com [material_ui]
Enable `tabs_test` (flutter/packages#12021)
2026-06-26 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `bottom_sheet_test.dart`
(flutter/packages#12001)
2026-06-26 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove widgets import in `dialog_test.dart`, `dropdown_menu_test.dart`
and `sliver_app_bar_test.dart` (flutter/packages#12002)
2026-06-26 stuartmorgan@google.com [various] Check in auto-upgrade to
analysis options (flutter/packages#11969)
2026-06-26 73310711+shrabanti722@users.noreply.github.com
[video_player_platform_interface] Add
preventsDisplaySleepDuringVideoPlayback option (flutter/packages#11546)
2026-06-26 nateshmbhat1@gmail.com [video_player_avfoundation] Add video
track selection support (flutter/packages#11476)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants