Skip to content

Update legacy test to be in Warn Range#12168

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jesswrd:fix-p0-roll
Jul 9, 2026
Merged

Update legacy test to be in Warn Range#12168
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jesswrd:fix-p0-roll

Conversation

@jesswrd

@jesswrd jesswrd commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I updated the error and warn versions in this PR: flutter/flutter#189109, which broke the flutter roll into packages. The legacy version was below the error version, so I upgraded the version to the error version (which is in the warn range).

Some helpful definitions:
[very low version, error version) --> in error range; app fails (legacy test fell in this range)
[error version, warn version) --> in warn range (warning logs)
[warn version, some very modern version) --> safe range (no logs)

Fixes: flutter/flutter#189218

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the legacy project CI configuration by upgrading the Gradle version from 8.11.1 to 8.14 and the Android Gradle Plugin (AGP) version from 8.9.1 to 8.11.1. These changes are reflected in the gradle-wrapper properties, settings.gradle, and the README documentation. There are no review comments, and I have no feedback to provide.

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2026
@auto-submit auto-submit Bot merged commit cf2f15c into flutter:main Jul 9, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter into packages autoroller broken due to Linux_android android_build_all_packages master failure

2 participants