[packages] Migrate all iOS example apps in flutter/packages to UIScene#12182
[packages] Migrate all iOS example apps in flutter/packages to UIScene#12182Zubii12 wants to merge 27 commits into
Conversation
a60a095 to
ce9c323
Compare
There was a problem hiding this comment.
Code Review
This pull request migrates the iOS examples of multiple packages to use UIScene and FlutterImplicitEngineDelegate, updating their AppDelegate and Info.plist configurations and bumping package versions. Review feedback highlights that the <key>UIApplicationSceneManifest</key> is missing before the <dict> element in the Info.plist files for extension_google_sign_in_as_googleapis_auth, file_selector, and file_selector_ios, which results in malformed plist files. Additionally, the Google Maps API key initialization was accidentally removed from the AppDelegate.swift of the google_maps_flutter example and needs to be restored.
| ) -> Bool { | ||
| GeneratedPluginRegistrant.register(with: self) | ||
| return super.application(application, didFinishLaunchingWithOptions: launchOptions) | ||
| } |
There was a problem hiding this comment.
I'll leave it to the iOS team to decide whether we want to keep all of these no-op overrides; generally we wouldn't have an override that did nothing but call super.
There was a problem hiding this comment.
There are a few examples already migrated to the UIScene lifecycle, they all keep this no-op method.
Let me know if you want me to remove them.
…sign_in example app to UIScene
38bcba3 to
2e83518
Compare
Migrate all iOS example apps in flutter/packages to UIScene lifecycle
Fixes flutter/flutter#188521
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2