Skip to content

[material_ui, cupertino_ui] Rename macro names to package names#12198

Open
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:rename-macro
Open

[material_ui, cupertino_ui] Rename macro names to package names#12198
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:rename-macro

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR rename macro names from flutter.material.* to material_ui.*, and flutter.cupertino.* to cupertino_ui.*.

These changes are not only aesthetic, but also functionally necessary, because the current macro names are also present in the Flutter framework. Since the dartdoc also read the framework, it will treat all macros/templates of the same name as duplicate entries, and will always display the macro content from the Flutter framework.

For example, the following screenshot shows the page of CupertinoCheckbox.fillColor as of 745da2e . Despite that we have long migrated it away from @tool snippet, they still shows @tool snippet because dartdoc is replaces the cupertino_ui doc with the content from the framework. This issue is fixed after this PR.

image

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 14, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 14, 2026
@dkwingsmt dkwingsmt requested a review from Piinks July 14, 2026 05:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation template and macro references across the cupertino_ui and material_ui packages, replacing the flutter.cupertino and flutter.material prefixes with cupertino_ui and material_ui respectively. The review feedback identifies a few incorrect macro and template references, including an incorrect macro reference for SimpleDialog.alignment and a duplicate template name for CupertinoTextSelectionToolbarButton.buttonItem.

Comment thread packages/material_ui/lib/src/dialog.dart
Comment thread packages/cupertino_ui/lib/src/text_selection_toolbar_button.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant