[material_ui, cupertino_ui] Rename macro names to package names#12198
Open
dkwingsmt wants to merge 1 commit into
Open
[material_ui, cupertino_ui] Rename macro names to package names#12198dkwingsmt wants to merge 1 commit into
dkwingsmt wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates documentation template and macro references across the cupertino_ui and material_ui packages, replacing the flutter.cupertino and flutter.material prefixes with cupertino_ui and material_ui respectively. The review feedback identifies a few incorrect macro and template references, including an incorrect macro reference for SimpleDialog.alignment and a duplicate template name for CupertinoTextSelectionToolbarButton.buttonItem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rename macro names from
flutter.material.*tomaterial_ui.*, andflutter.cupertino.*tocupertino_ui.*.These changes are not only aesthetic, but also functionally necessary, because the current macro names are also present in the Flutter framework. Since the
dartdocalso read the framework, it will treat all macros/templates of the same name as duplicate entries, and will always display the macro content from the Flutter framework.For example, the following screenshot shows the page of
CupertinoCheckbox.fillColoras of 745da2e . Despite that we have long migrated it away from@tool snippet, they still shows@tool snippetbecausedartdocis replaces thecupertino_uidoc with the content from the framework. This issue is fixed after this PR.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2