Add retries to fuchsia paving.

packages/fuchsia_ctl/CHANGELOG.md

@@ -1,5 +1,15 @@
 # CHANGELOG
 
+
+
+## 0.0.18 - 0.0.21
+
+- Add retries to paving operations.
+- Add timeouts to paving and ssh operations.
+- Add arguments parameter to test command.
+
+
+
 ## 0.0.17
 
 - Add "push-packages" option.

packages/fuchsia_ctl/bin/main.dart

@@ -13,6 +13,7 @@ import 'package:fuchsia_ctl/src/operation_result.dart';
 import 'package:fuchsia_ctl/src/tar.dart';
 import 'package:meta/meta.dart';
 import 'package:path/path.dart' as path;
+import 'package:retry/retry.dart';
 import 'package:uuid/uuid.dart';
 
 typedef AsyncResult = Future<OperationResult> Function(
@@ -163,11 +164,21 @@ Future<OperationResult> pave(
   ArgResults args,
 ) async {
   const ImagePaver paver = ImagePaver();
-  return await paver.pave(
-    args['image'],
-    deviceName,
-    publicKeyPath: args['public-key'],
+  const RetryOptions r = RetryOptions(
+    maxDelay: Duration(seconds: 30),
+    maxAttempts: 3,
   );
+  return await r.retry(() async {
+    final OperationResult result = await paver.pave(
+      args['image'],
+      deviceName,
+      publicKeyPath: args['public-key'],
+    );
+    if (!result.success) {
+      throw RetryException('Exit code different from 0', result);
+    }
+    return result;
+  }, retryIf: (Exception e) => e is RetryException);
 }
 
 @visibleForTesting
@@ -309,3 +320,20 @@ Future<OperationResult> test(
     }
   }
 }
+
+/// The exception thrown when an operation needs a retry.
+class RetryException implements Exception {
+  /// Creates a new [RetryException] using the specified [cause] and [result]
+  /// to force a retry.
+  const RetryException(this.cause, this.result);
+
+  /// The user-facing message to display.
+  final String cause;
+
+  /// Contains the result of the executed target command.
+  final OperationResult result;
+
+  @override
+  String toString() =>
+      '$runtimeType, cause: "$cause", underlying exception: $result.';
+}

packages/fuchsia_ctl/pubspec.yaml

@@ -4,7 +4,7 @@ description: >
   Fuchsia Device. This package is primarily intended for use in Flutter's
   continuous integration/testing infrastructure.
 homepage: https://github.com/flutter/packags/tree/master/packages/fuchsia_ctl
-version: 0.0.17
+version: 0.0.21
 
 environment:
   sdk: ">=2.4.0 <3.0.0"
@@ -15,6 +15,7 @@ dependencies:
   meta: ^1.1.7
   path: ^1.6.4
   process: ^3.0.12
+  retry: ^3.0.0+1
   uuid: ^2.0.2
 
 dev_dependencies: