Skip to content

[animations] Adds opaque argument to OpenContainer. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HelloChunWei wants to merge 1 commit into from
Closed

[animations] Adds opaque argument to OpenContainer. #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/animations/lib/src/open_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ class OpenContainer<T extends Object> extends StatefulWidget {
this.transitionDuration = const Duration(milliseconds: 300),
this.transitionType = ContainerTransitionType.fade,
this.useRootNavigator = false,
this.opaque = true,
}) : assert(closedColor != null),
assert(openColor != null),
assert(closedElevation != null),
Expand All @@ -107,6 +108,7 @@ class OpenContainer<T extends Object> extends StatefulWidget {
assert(tappable != null),
assert(transitionType != null),
assert(useRootNavigator != null),
assert(opaque != null),
super(key: key);

/// Background color of the container while it is closed.
Expand Down Expand Up @@ -246,6 +248,11 @@ class OpenContainer<T extends Object> extends StatefulWidget {
/// to the nearest navigator.
final bool useRootNavigator;

/// Whether the route obscures previous routes when the transition is complete.

@goderbauer goderbauer Oct 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove leading space.

/// When [opaque] is true, the route obscures previous routes.

@goderbauer goderbauer Oct 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a blank line before this line.

/// By default, [opaque] is true.
final bool opaque;

@override
_OpenContainerState<T> createState() => _OpenContainerState<T>();
}
Expand Down Expand Up @@ -281,6 +288,7 @@ class _OpenContainerState<T> extends State<OpenContainer<T>> {
transitionDuration: widget.transitionDuration,
transitionType: widget.transitionType,
useRootNavigator: widget.useRootNavigator,
opaque: widget.opaque,
));
if (widget.onClosed != null) {
widget.onClosed(data);
Expand Down Expand Up @@ -394,6 +402,7 @@ class _OpenContainerRoute<T> extends ModalRoute<T> {
@required this.transitionDuration,
@required this.transitionType,
@required this.useRootNavigator,
this.opaque = true,
}) : assert(closedColor != null),
assert(openColor != null),
assert(closedElevation != null),
Expand All @@ -405,6 +414,7 @@ class _OpenContainerRoute<T> extends ModalRoute<T> {
assert(closedBuilderKey != null),
assert(transitionType != null),
assert(useRootNavigator != null),
assert(opaque != null),
_elevationTween = Tween<double>(
begin: closedElevation,
end: openElevation,
Expand Down Expand Up @@ -546,6 +556,8 @@ class _OpenContainerRoute<T> extends ModalRoute<T> {

@override
final Duration transitionDuration;
@override
final bool opaque;
final ContainerTransitionType transitionType;

final bool useRootNavigator;
Expand Down Expand Up @@ -848,9 +860,6 @@ class _OpenContainerRoute<T> extends ModalRoute<T> {
@override
Color get barrierColor => null;

@override
bool get opaque => true;

@override
bool get barrierDismissible => false;

Expand Down