-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Create PULL_REQUEST_TEMPLATE.md #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| *Replace this paragraph with a description of what this PR is changing or adding, and why.* | ||
|
|
||
| *List which issues are fixed by this PR. You must list at least one issue.* | ||
|
|
||
| *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* | ||
|
|
||
| ## Pre-launch Checklist | ||
|
|
||
| - [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` | ||
| - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. | ||
| - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. | ||
| - [ ] I read and followed the [Flutter Style Guide]. | ||
| - [ ] I listed at least one issue that this PR fixes in the description above. | ||
| - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. | ||
| - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy]. | ||
| - [ ] I updated `CHANGELOG.md` to add a description of the change. | ||
| - [ ] I updated/added relevant documentation (doc comments with `///`). | ||
| - [ ] I signed the [CLA]. | ||
| - [ ] All existing and new tests are passing. | ||
|
|
||
| If you need help, consider asking for advice on the `#hackers-new` channel on [Discord]. | ||
|
|
||
| <!-- Links --> | ||
| [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview | ||
| [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene | ||
| [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo | ||
| [CLA]: https://cla.developers.google.com/ | ||
| [flutter/tests]: https://github.com/flutter/tests | ||
| [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes | ||
| [Discord]: https://github.com/flutter/flutter/wiki/Chat | ||
| [pub versioning philosophy]: https://dart.dev/tools/pub/versioning | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use 💭 instead of
new?(I didn't understand the meaning of this emoji until now lol)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full name is
#hackers-new-🐣, but we might change the emoji on people and the name is what really matters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought that contributors might use hackers-💭 more often right now.