[pigeon] Consolidate platform test harnesses part 1 - harnesses#2809
Merged
auto-submit[bot] merged 16 commits intoNov 15, 2022
Merged
Conversation
stuartmorgan-g
added
override: no versioning needed
stuartmorgan-g
requested review from
gaaclarke and
tarrinneal
as code owners
stuartmorgan-g
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tarrinneal
approved these changes
Nov 15, 2022
tarrinneal
left a comment
tarrinneal
left a comment
Contributor
There was a problem hiding this comment.
Seems like everything here is solid
stuartmorgan-g
added
the
autosubmit
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…ter#2809) * Add README explaining structure * Initial test plugin; unchanged from template * Initial seconday test plugin; unchanged from template * Misc template cleanup, and add generated files. * README cleanup * Analyzer fix * Autoformat * Misc repo check fixes * Roll back Gradle and AGP version for macOS CI * Delete unneeded template files * Adjust READMEs * Add integration test issue reference * Remove obsolete workaround from CI * Revert script change that doesn't belong here * Revert autoformat that belongs to a later PR * Autoformat
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…ter#2809) * Add README explaining structure * Initial test plugin; unchanged from template * Initial seconday test plugin; unchanged from template * Misc template cleanup, and add generated files. * README cleanup * Analyzer fix * Autoformat * Misc repo check fixes * Roll back Gradle and AGP version for macOS CI * Delete unneeded template files * Adjust READMEs * Add integration test issue reference * Remove obsolete workaround from CI * Revert script change that doesn't belong here * Revert autoformat that belongs to a later PR * Autoformat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #2803
Adds two plugins—one for most languages, one for alternate languages (Java and Obj-C)—to serve as native test hosts, to consolidate everything into a multi-platform test harness that uses exactly the same structure as all of the native unit tests in flutter/plugins.
This PR is a no-op in terms of the actual test script; it adds the scaffolding with nothing using it yet. Each test will be moved in a separate follow-up PR to isolate the CI issues in #2803. This portion corresponds to:
flutter create.This does preemptively remove a Cirrus CI workaround for dart-lang/pub#3618, since that is now fixed upstream, and removing it now avoids needing to update the workaround in every follow-up PR.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).