[pigeon] Add the iOS tests in the new harness as non-default options#2867
Merged
tarrinneal merged 14 commits intoNov 30, 2022
Merged
Conversation
Collaborator
Author
|
(Once this lands, I'll rebase #2816 and it should become all deletion, so it won't keep getting stale.) |
tarrinneal
approved these changes
Nov 30, 2022
11 tasks
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#2867) * Move Obj-C tests into the new harness * Modernize imports in ObjC tests * Fix new generation code for merge * Plumb in new integration tests * Format * Add Dart-based support for the new unit test harness * Restore the old path in run_tests.sh * Restore ios_unit_tests temporarily, but with symlinks * Point to new location for generated files * Hack the imports to work in both locations * Switch from symlinks to project location changes * Update README
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…lutter#2867) * Move Obj-C tests into the new harness * Modernize imports in ObjC tests * Fix new generation code for merge * Plumb in new integration tests * Format * Add Dart-based support for the new unit test harness * Restore the old path in run_tests.sh * Restore ios_unit_tests temporarily, but with symlinks * Point to new location for generated files * Hack the imports to work in both locations * Switch from symlinks to project location changes * Update README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an interim solution to get the ObjC tests into the new combined harness while the CI blocking issues in #2816 are being resolved. This is based on that PR, with the following changes:
platform_tests/unit_tests_ios/is restored, but without any of the source files; the project has been modified to point to the locations of those files in the new harness.alternate_language_test_pluginmodule there), so there's an#ifdef-based inclusion of the old approach for now.ios_unitteststest target inrun_tests.shhas been changed back to running the old harness, so that CI will continue to work as is.ios_objc_unitteststarget inrun_tests.sh(which is the name we actually want going forward) has been added, and like the other new tests is just a passthrough to a newrun_tests.dartimplementation.This will allow us to land the migration to the new harness now, which will avoid the problem of that PR constantly becoming outdated as we make changes in the new harness, while leaving the old harness in place for CI until the CI problems with ARM Cirrus can be resolved (which could be another month), at the cost of having duplicate harnesses for now. Since it's only the project that's duplicated though, not the source, we'll only have to touch the old harness if we are actually changing the included files (most likely that would just be
pigeons/consolidation PRs), which should be a small cost.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).