[pigeon] Remove legacy iOS unit test harness#2868
Closed
stuartmorgan-g wants to merge 1 commit into
Closed
Conversation
Removes the legacy iOS unit test harness, `platform_tests/ios_unit_test`, and enables the new harness by default in run_tests.sh (and thus in CI). Also enables the iOS integration tests in the new harness by default.
stuartmorgan-g
added
override: no versioning needed
Collaborator
Author
|
This is the successor to #2816; it will have the same blocking CI issues. |
This was referenced Dec 1, 2022
Collaborator
Author
|
I tried this as an Intel LUCI task in #2869 and it also hung there, so it seems like this isn't just the ARM thing. I'll have to keep digging into why this hangs in CI but not locally. |
Collaborator
Author
|
Obsoleted by the recent partial LUCI migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy iOS unit test harness,
platform_tests/ios_unit_test, and enables the new harness by default in run_tests.sh (and thus in CI).Also enables the iOS integration tests in the new harness by default.
See #2816 for background.
Part of flutter/flutter#111505
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).