Skip to content

[pigeon] refactored the AST#427

Closed
gaaclarke wants to merge 32 commits into
flutter:masterfrom
gaaclarke:pigeon-stuart-ast-changes
Closed

[pigeon] refactored the AST#427
gaaclarke wants to merge 32 commits into
flutter:masterfrom
gaaclarke:pigeon-stuart-ast-changes

Conversation

@gaaclarke

Copy link
Copy Markdown
Member

Over the course of working through backlogged PRs there was feedback on the structure of the AST. I've addressed them here by:

  1. Introducing the concept of the TypeDeclaration
  2. Renamed Field to NamedType
  3. Transitioned the return value for methods to a TypeDeclaration

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the pigeon-stuart-ast-changes branch from 3f1574f to d70f83b Compare August 3, 2021 20:12
@gaaclarke

Copy link
Copy Markdown
Member Author

subsumed by #428

@gaaclarke gaaclarke closed this Aug 3, 2021
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Provide a value for HttpResponse.compressionState in the network test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant