[camerax] Wrap classes to implement resolution configuration for video capture#4620
Merged
Conversation
11 tasks
Member
|
A couple of comments on the dart code, but mostly documentation suggestions. Mostly looks good though! |
…gy.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…r.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…r.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…r.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…r.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…r.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
….dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
gmackall
approved these changes
Aug 14, 2023
gmackall
left a comment
gmackall
left a comment
Member
There was a problem hiding this comment.
LGTM outside of 3 comment changes!
…o/flutter/plugins/camerax/FallbackStrategyHostApiImpl.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…o/flutter/plugins/camerax/QualitySelectorHostApiImpl.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…gy.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
camsim99
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/4620, due to - The status or check suite version_check has failed. Please fix the issues identified (or deflake) before re-applying this label. |
camsim99
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2023
flutter/packages@84218b9...9bf208f 2023-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 9b6945b to f0e7c51 (63 revisions) (flutter/packages#4719) 2023-08-15 31859944+LongCatIsLooong@users.noreply.github.com Update palette_generator_test.dart (flutter/packages#4720) 2023-08-15 mit@google.com [pigeon] Fix typo in README.md (flutter/packages#4707) 2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716) 2023-08-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563) 2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620) 2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…o capture (flutter#4620) Wraps classes to implement resolution configuration for video capture. No functionality changes. Part of flutter/flutter#120462.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…o capture (flutter#4620) Wraps classes to implement resolution configuration for video capture. No functionality changes. Part of flutter/flutter#120462.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps classes to implement resolution configuration for video capture. No functionality changes.
Part of flutter/flutter#120462.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).