[webview_flutter] Support for handling basic authentication requests (Android)#5454
Merged
auto-submit[bot] merged 43 commits intoDec 13, 2023
Merged
Conversation
…/packages into webview-auth-request
…b/src/types/http_auth_request.dart
…s into webview-auth-request
bparrishMines
approved these changes
Nov 29, 2023
bparrishMines
left a comment
bparrishMines
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@stuartmorgan for secondary review
| ) { | ||
| final void Function(HttpAuthRequest)? callback = | ||
| weakThis.target?._onHttpAuthRequest; | ||
| if (callback != null) { |
Collaborator
There was a problem hiding this comment.
Don't we need a default reply when there's no handler like we have on iOS?
Contributor
There was a problem hiding this comment.
That's a good catch. I updated the PR
stuartmorgan-g
approved these changes
Dec 13, 2023
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
It would be good to have a test that the default handler is there and works (i.e., one that would have failed before the fix made for my previous comment), but that could be a follow-up.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567) 2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merged
11 tasks
11 tasks
Closed
auto-submit Bot
pushed a commit
that referenced
this pull request
Jan 13, 2024
…s cancelled by default (#5723) Added test in response to feedback from #5454 (review) Also regenerates mock files.
12 tasks
auto-submit Bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
…5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455. Issues fixed by PR: Closes flutter/flutter#83556
16 tasks
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…(Android) (flutter#5454) Adds the Android implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…s cancelled by default (flutter#5723) Added test in response to feedback from flutter#5454 (review) Also regenerates mock files.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are flutter#5362, flutter#5454 and flutter#5455. Issues fixed by PR: Closes flutter/flutter#83556
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…(Android) (flutter#5454) Adds the Android implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…s cancelled by default (flutter#5723) Added test in response to feedback from flutter#5454 (review) Also regenerates mock files.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…lutter#5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are flutter#5362, flutter#5454 and flutter#5455. Issues fixed by PR: Closes flutter/flutter#83556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Android implementation for basic http authentication.
This PR is part of a series of PRs that aim to close flutter/flutter#83556.
The PR that contains all changes can be found at #4140.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).