Skip to content

[google_sign_in_ios] Move pigeon as a dev dependency#5685

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
davidmartos96:pigeon_dev_dep
Dec 15, 2023
Merged

[google_sign_in_ios] Move pigeon as a dev dependency#5685
auto-submit[bot] merged 1 commit into
flutter:mainfrom
davidmartos96:pigeon_dev_dep

Conversation

@davidmartos96

@davidmartos96 davidmartos96 commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Fixes: flutter/flutter#140213

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g
stuartmorgan-g approved these changes Dec 15, 2023
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a style nit for the CHANGELOG.

Thanks for fixing this! I'm not sure how I did that in the first place.

Comment thread packages/google_sign_in/google_sign_in_ios/CHANGELOG.md Outdated
@davidmartos96

davidmartos96 commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

@stuartmorgan I updated the changelog with the suggestion.
But it looks like your email (now as co-author) is not in the Google CLA. Should I force push?

@stuartmorgan-g

stuartmorgan-g commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

Ugh, sorry about that. For some reason no matter how many times I change it, GitHub always wants to use my personal email address by default for changes I make via the UI, and I didn't notice. I think you will indeed have to force-push to erase that commit.

So much for making my comment easier to apply...

@davidmartos96

davidmartos96 commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

@stuartmorgan Done!

tarrinneal
tarrinneal approved these changes Dec 15, 2023
View reviewed changes

@tarrinneal tarrinneal left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could update the pigeon version. Probably not worth the effort.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit Bot merged commit 3740e33 into flutter:main Dec 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
3740e33 [google_sign_in_ios] Move pigeon as a dev dependency (flutter…
495b4ae 
…/packages#5685)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
Roll Packages from 3f2e16b to d7dee79 (5 revisions) (#140322)
63753d4 
flutter/packages@3f2e16b...d7dee79

2023-12-16 tarrinneal@gmail.com Remove flutter api named and optional parameters (flutter/packages#5689)
2023-12-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692)
2023-12-15 mikemcguiness@protonmail.com [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in � (flutter/packages#5496)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691)
2023-12-15 davidmartos96@gmail.com [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll @CoderDake
Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter#140322)
d92edfa 
flutter/packages@3f2e16b...d7dee79

2023-12-16 tarrinneal@gmail.com Remove flutter api named and optional parameters (flutter/packages#5689)
2023-12-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692)
2023-12-15 mikemcguiness@protonmail.com [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in � (flutter/packages#5496)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691)
2023-12-15 davidmartos96@gmail.com [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
@davidmartos96 davidmartos96 deleted the pigeon_dev_dep branch October 27, 2025 08:49
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@davidmartos96
[google_sign_in_ios] Move pigeon as a dev dependency (flutter#5685)
51a25f6 
Fixes: flutter/flutter#140213
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@davidmartos96
[google_sign_in_ios] Move pigeon as a dev dependency (flutter#5685)
b06174c 
Fixes: flutter/flutter#140213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes
@tarrinneal tarrinneal tarrinneal approved these changes
@vashworth vashworth Awaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_sign_in_ios] Using pigeon as a regular dependency

3 participants

@davidmartos96 @stuartmorgan-g @tarrinneal