[many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0)#7521
Merged
Conversation
8.1.0+8.1.0+
8.1.0+
gmackall
commented
Aug 27, 2024
Contributor
|
test-exempt: The example apps are the tests. |
Member
Author
|
Overriding the repo checks: The only non-auto-exempted change is a deletion of a gradle wrapper that didn't need to exist. |
Contributor
|
auto label is removed for flutter/packages/7521, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/packages/7521, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vasilich6107
pushed a commit
to artflutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
`rfw` has multiple example apps - I missed this one in #7521. Also missed `extension_google_sign_in_as_googleapis_auth` - will need to upgrade that in a follow up PR (it has additional failures after the AGP upgrade, so it isn't a one line fix).
11 tasks
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…] Manual roll with fixes to example and skipping some native tests (#7571) It looks like #7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
dko5ki23t
pushed a commit
to dko5ki23t/google_maps_flutter_improved
that referenced
this pull request
May 24, 2025
…] Manual roll with fixes to example and skipping some native tests (#7571) It looks like flutter/packages#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
Jyndigo
pushed a commit
to uesp/wkwebview_flutter
that referenced
this pull request
Jun 24, 2025
…] Manual roll with fixes to example and skipping some native tests (#7571) It looks like flutter/packages#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
Jyndigo
pushed a commit
to uesp/wkwebview_flutter
that referenced
this pull request
Apr 15, 2026
…] Manual roll with fixes to example and skipping some native tests (#7571) It looks like flutter/packages#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#7521) For flutter/flutter#153795 - specifically the bump to `compileSdk 35` requires AGP 8.1.0+ (this isn't documented anywhere, but folks on https://issuetracker.google.com/issues/342522139 are also experiencing it). Upgrades to AGP 8.5.2 and Gradle 8.7, for example apps that were using AGP less than 8.1.0. Unblocks framework->packages roller
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
`rfw` has multiple example apps - I missed this one in flutter#7521. Also missed `extension_google_sign_in_as_googleapis_auth` - will need to upgrade that in a follow up PR (it has additional failures after the AGP upgrade, so it isn't a one line fix).
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…] Manual roll with fixes to example and skipping some native tests (flutter#7571) It looks like flutter#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…lutter#7521) For flutter/flutter#153795 - specifically the bump to `compileSdk 35` requires AGP 8.1.0+ (this isn't documented anywhere, but folks on https://issuetracker.google.com/issues/342522139 are also experiencing it). Upgrades to AGP 8.5.2 and Gradle 8.7, for example apps that were using AGP less than 8.1.0. Unblocks framework->packages roller
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
`rfw` has multiple example apps - I missed this one in flutter#7521. Also missed `extension_google_sign_in_as_googleapis_auth` - will need to upgrade that in a follow up PR (it has additional failures after the AGP upgrade, so it isn't a one line fix).
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…] Manual roll with fixes to example and skipping some native tests (flutter#7571) It looks like flutter#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#153795 - specifically the bump to
compileSdk 35requires AGP 8.1.0+ (this isn't documented anywhere, but folks on https://issuetracker.google.com/issues/342522139 are also experiencing it).Upgrades to AGP 8.5.2 and Gradle 8.7, for example apps that were using AGP less than 8.1.0.
Unblocks framework->packages roller
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.