Skip to content

[in_app_purchase_storekit] Add support for purchase and transactions#7574

Merged
auto-submit[bot] merged 34 commits into
flutter:mainfrom
LouiseHsu:iap_add_purchase
Oct 7, 2024
Merged

[in_app_purchase_storekit] Add support for purchase and transactions#7574
auto-submit[bot] merged 34 commits into
flutter:mainfrom
LouiseHsu:iap_add_purchase

Conversation

@LouiseHsu

@LouiseHsu LouiseHsu commented Sep 3, 2024 •
edited by jmagman
Loading

Copy link
Copy Markdown
Contributor

This PR contains the preliminary implementations for handling purchases and transactions

Of note, as of StoreKit 2, the result of a call to a purchase will only return a Transaction when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned.

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with TransactionState. This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LouiseHsu LouiseHsu changed the title pigeon stuff [in_app_purchase_storekit] Add support for purchase and transactions Sep 4, 2024
@jmagman jmagman mentioned this pull request Sep 24, 2024
Open
@LouiseHsu LouiseHsu marked this pull request as ready for review September 27, 2024 18:34
hellohuanlin
hellohuanlin approved these changes Oct 2, 2024
View reviewed changes

@hellohuanlin hellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the nits

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 7, 2024
@auto-submit auto-submit Bot merged commit 2203d08 into flutter:main Oct 7, 2024
hellohuanlin
hellohuanlin reviewed Oct 7, 2024
View reviewed changes
Comment thread packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift
private var _updateListenerTask: Any?

@available(iOS 13.0, *)
var getListenerTaskAsTask: Task<(), Never> {

@hellohuanlin hellohuanlin Oct 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change it in next PR - getter shouldn't have a get prefix. It should be just var updateListenerTask: Task<(), Never>

@stuartmorgan-g stuartmorgan-g mentioned this pull request Oct 7, 2024
Merged
stuartmorgan-g added a commit that referenced this pull request Oct 7, 2024
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
f0d51c6 
…actions" (#7810)

Reverts #7574

This is failing for `stable` (which only runs in post-submit). See
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734714858533469745/+/u/Run_package_tests/native_test/stdout
for errors.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2024
@engine-flutter-autoroll
2203d08 [in_app_purchase_storekit] Add support for purchase and trans…
3459049 
…actions (flutter/packages#7574)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Oct 8, 2024
@engine-flutter-autoroll
Roll Packages from bb00d34 to 8fbf4cd (10 revisions) (#156407)
49ccfdb 
flutter/packages@bb00d34...8fbf4cd

2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) (flutter/packages#7815)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 6bba08c to 0975e61 (1 revision) (flutter/packages#7814)
2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.1 (flutter/packages#7813)
2024-10-08 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdsRenderingSettings` (flutter/packages#7745)
2024-10-08 stuartmorgan@google.com [url_launcher] Remove incorrect SMS instructions (flutter/packages#7807)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ead6b0d to 6bba08c (37 revisions) (flutter/packages#7809)
2024-10-07 jtanium@gmail.com [webview_flutter_wkwebview] Support NTLM for authentication (flutter/packages#7670)
2024-10-07 stuartmorgan@google.com Revert "[in_app_purchase_storekit] Add support for purchase and transactions" (flutter/packages#7810)
2024-10-07 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7574)
2024-10-07 engine-flutter-autoroll@skia.org Manual roll Flutter from fa402c8 to ead6b0d (14 revisions) (flutter/packages#7806)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LouiseHsu LouiseHsu mentioned this pull request Oct 8, 2024
Merged
11 tasks
auto-submit Bot pushed a commit that referenced this pull request Oct 17, 2024
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions #…
c1435ed 
…7574 (#7812)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands #7574
auto-submit Bot pushed a commit that referenced this pull request Oct 17, 2024
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
870114d 
…actions #7574" (#7886)

Reverts #7812

See #7812 (comment)
@LouiseHsu LouiseHsu mentioned this pull request Oct 17, 2024
Merged
11 tasks
auto-submit Bot pushed a commit that referenced this pull request Oct 17, 2024
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions (#…
e19503e 
…7887)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands #7574
@jmagman jmagman mentioned this pull request Oct 24, 2024
Closed
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions (f…
bba7f5b 
…lutter#7574)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
e2438a5 
…actions" (flutter#7810)

Reverts flutter#7574

This is failing for `stable` (which only runs in post-submit). See
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734714858533469745/+/u/Run_package_tests/native_test/stdout
for errors.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions f…
397dcfd 
…lutter#7574 (flutter#7812)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands flutter#7574
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
daaf8bb 
…actions flutter#7574" (flutter#7886)

Reverts flutter#7812

See flutter#7812 (comment)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions (f…
b1c08bd 
…lutter#7887)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands flutter#7574
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions (f…
d419c87 
…lutter#7574)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
3d229c7 
…actions" (flutter#7810)

Reverts flutter#7574

This is failing for `stable` (which only runs in post-submit). See
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734714858533469745/+/u/Run_package_tests/native_test/stdout
for errors.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions f…
f91c9aa 
…lutter#7574 (flutter#7812)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands flutter#7574
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
Revert "[in_app_purchase_storekit] Add support for purchase and trans…
1f81285 
…actions flutter#7574" (flutter#7886)

Reverts flutter#7812

See flutter#7812 (comment)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@LouiseHsu
[in_app_purchase_storekit] Add support for purchase and transactions (f…
b6b8fa3 
…lutter#7887)

This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) 

Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. 

This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. 

Relands flutter#7574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LouiseHsu @hellohuanlin