[google_maps_flutter_android] Convert PlatformPolyline.pattern to Pigeon#7631
Merged
Conversation
reidbaker
reviewed
Sep 12, 2024
stuartmorgan-g
requested changes
Sep 12, 2024
11 tasks
stuartmorgan-g
approved these changes
Sep 14, 2024
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with the re-addition of dead code removed.
|
|
||
| private static int toPixels(Object o, float density) { | ||
| return (int) toFractionalPixels(o, density); | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this a bad merge? This is re-introducing unused, non-Pigeon conversion code.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…igeon (flutter#7631) Creates a structured `PlatformPatternItem` pigeon class to use in `PlatformPolyline`. flutter/flutter#154738 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…igeon (flutter#7631) Creates a structured `PlatformPatternItem` pigeon class to use in `PlatformPolyline`. flutter/flutter#154738 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a structured
PlatformPatternItempigeon class to use inPlatformPolyline.flutter/flutter#154738
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.