Skip to content

[package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0#7704

Merged
devoncarew merged 3 commits into
flutter:mainfrom
devoncarew:flutter_lints_5.0.0
Sep 25, 2024
Merged

[package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0#7704
devoncarew merged 3 commits into
flutter:mainfrom
devoncarew:flutter_lints_5.0.0

Conversation

@devoncarew

Copy link
Copy Markdown
Contributor
  • rev package:flutter_lints to 5.0.0 in prep for publishing
  • update our dep on package:lints to the latest stable published version (5.0.0)
  • update our sdk dep to reflect the package:lints one
  • update the changelog to reflect the new changes brought in from package:lints

Closes dart-lang/core#833.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@devoncarew

Copy link
Copy Markdown
Contributor Author

@stuartmorgan for review (and cc @Piinks and @goderbauer for fyi)

@stuartmorgan-g

stuartmorgan-g commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

rev to 5.0.0 in prep for publishing

In flutter/packages this doesn't prepare for publishing, landing this PR actually publishes the package. We generally give the PR a name describing the change itself rather than the version change (e.g., "[flutter_lints] Update lints to 5.0 and adjust additional lints") to make the history more informative.

@devoncarew devoncarew changed the title [package:flutter_lints] rev to 5.0.0 in prep for publishing [package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0 Sep 25, 2024
@devoncarew

Copy link
Copy Markdown
Contributor Author

We generally give the PR a name describing the change itself rather than the version change (e.g., "[flutter_lints] Update lints to 5.0 and adjust additional lints") to make the history more informative.

👍 ; updated the title to [package:flutter_lints] update the dep on package:lints to 5.0.0 and the sdk dependency to 3.5.0.

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog style nit

Comment thread packages/flutter_lints/CHANGELOG.md Outdated
Comment thread packages/flutter_lints/CHANGELOG.md Outdated
@devoncarew devoncarew merged commit f38b780 into flutter:main Sep 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Sep 26, 2024
flutter/packages@7da2374...f38b780

2024-09-25 devoncarew@google.com [package:flutter_lints] update the dep on `package:lints` to 5.0.0 and the sdk dependency to 3.5.0 (flutter/packages#7704)
2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter from 4ca51a1 to 538e742 (40 revisions) (flutter/packages#7705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…d the sdk dependency to 3.5.0 (flutter#7704)

- rev `package:flutter_lints` to 5.0.0 in prep for publishing
- update our dep on package:lints to the latest stable published version
(`5.0.0`)
- update our sdk dep to reflect the package:lints one
- update the changelog to reflect the new changes brought in from
package:lints

Closes https://github.com/dart-lang/lints/issues/205.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…d the sdk dependency to 3.5.0 (flutter#7704)

- rev `package:flutter_lints` to 5.0.0 in prep for publishing
- update our dep on package:lints to the latest stable published version
(`5.0.0`)
- update our sdk dep to reflect the package:lints one
- update the changelog to reflect the new changes brought in from
package:lints

Closes https://github.com/dart-lang/lints/issues/205.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the annoying const lints from flutter_lints

2 participants