Skip to content

[in_app_purchase_storekit] Updated comment #9445

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
avni-prajapati:fix/storekit-comment
Jul 31, 2025
Merged

[in_app_purchase_storekit] Updated comment #9445
auto-submit[bot] merged 1 commit into
flutter:mainfrom
avni-prajapati:fix/storekit-comment

Conversation

@avni-prajapati

@avni-prajapati avni-prajapati commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Updated the comment refer to StoreKit instead of Android, in example/lib/main.dart

Before

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the Android plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();

After

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the StoreKit plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();

Issue

Closes flutter/flutter#159623

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@LongCatIsLooong LongCatIsLooong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, thanks for the fix!

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

From triage: @LouiseHsu This still needs a secondary review to land.

@vashworth vashworth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2025
@auto-submit auto-submit Bot merged commit b2aef15 into flutter:main Jul 31, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2025
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 6, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
flutter/packages@db6988d...f0645d8

2025-08-01 bkonyi@google.com Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 154810109+avni-prajapati@users.noreply.github.com
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 stuartmorgan@google.com [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
### *Updated the comment refer to `StoreKit` instead of `Android`, in example/lib/main.dart*

### Before 
```dart
void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the Android plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();
```
### After
```dart
void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the StoreKit plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();
```

### Issue
Closes flutter/flutter#159623

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
### *Updated the comment refer to `StoreKit` instead of `Android`, in example/lib/main.dart*

### Before 
```dart
void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the Android plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();
```
### After
```dart
void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the StoreKit plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();
```

### Issue
Closes flutter/flutter#159623

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos triage-ios Should be looked at in iOS triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Comment in example/lib/main.dart may be incorrect.

4 participants