copy and presentaion#2094
Closed
pedromorgan wants to merge 2 commits into
Closed
Conversation
make it more understandable with links etc..
googlebot
added
the
cla: yes
small tweaks to tab controller
brianegan
requested changes
Feb 13, 2019
brianegan
left a comment
brianegan
left a comment
Contributor
There was a problem hiding this comment.
Overall, I like the changes! One note: Please ensure the lines do not go past an 80 character limit (unless they have to, such as with links).
| the [material library](https://docs.flutter.io/flutter/material/material-library.html). | ||
|
|
||
| ## Directions | ||
| ## Steps |
Contributor
There was a problem hiding this comment.
Let's keep directions, please! Used everywhere else in the cookbook.
| In order for tabs to work, we'll need to keep the selected tab and content | ||
| sections in sync. This is the job of the [`TabController`](https://docs.flutter.io/flutter/material/TabController-class.html). | ||
| The purpose of the [`TabController`](https://docs.flutter.io/flutter/material/TabController-class.html), | ||
| is to coordinate the selected `Tab` in the `TabBar` and content in `TabBarView`. |
Contributor
There was a problem hiding this comment.
"content in the TabBarView. "?
| [`DefaultTabController`](https://docs.flutter.io/flutter/material/DefaultTabController-class.html) | ||
| Widget. Using the `DefaultTabController` is the simplest option, since it will | ||
| create a `TabController` for us and make it available to all descendant Widgets. | ||
| A `TabController` can be either: |
Contributor
There was a problem hiding this comment.
I like the idea of this section, but the language is a bit awkward. Maybe:
A
TabControllercan be:
- Created manually
- Created automatically by using a
DefaultTabControllerWidgetUsing the
DefaultTabControlleris the simplest...
Contributor
|
I'm incorporating some of this in another PR: #2711 Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make it more understandable with links etc..