Update using Flutter from China by atsansone · Pull Request #9338 · flutter/website

atsansone · 2023-08-31T21:20:03Z

Staged at https://flutter-docs-prod--pr9338-fix-2556-92qeer86.web.app/community/china

parlough · 2023-09-01T06:54:36Z

+
+To configure a proxy, check out the [Dart documentation on proxies][].
+
+[Dart documentation on proxies]: {{dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall


To fix the link and build:

Suggested change

[Dart documentation on proxies]: {{dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall

[Dart documentation on proxies]: {{site.dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall

parlough · 2023-09-01T07:00:55Z

+using the `flutter-io.cn` server, consider reporting the issue to
 [the issue tracker (镜像问题)](https://github.com/cfug/flutter.cn/issues/new/choose).

+## Publishing apps


Taking a look at the source issue, it seems your addition covers half of the issue.

If I understood the issue correct, the other is that you can't publish to the mirror. So if a user followed the steps in Configuring Flutter to use a mirror site and changed your PUB_HOSTED_URL, publishing won't work. I guess they need to remove this override to publish.

AlexV525 · 2023-10-26T06:11:40Z

@atsansone Are you still on this?

atsansone

@jonasfj : I reworked this heavily to make it more clear. Let me know your thoughts.

@parlough : You can review again, but there may be commentary from Chinese community members yet to be reconciled.

AlexV525 · 2023-10-28T06:50:42Z

cc @skyzh to review SJTUG-related content.

atsansone · 2023-10-29T04:43:21Z

@AlexV525 : You are awesome! Thanks for this SME feedback!

skyzh

rest LGTM, thanks for the pull request!

AlexV525 · 2023-10-31T01:54:05Z

What about the general idea of making this page written or translated in Simplified Chinese?

Co-authored-by: Alex Li <github@alexv525.com>

@AlexV525

@AlexV525 : Great help on this. Thanks! Co-authored-by: Alex Li <github@alexv525.com>

Co-authored-by: Alex Li <github@alexv525.com>

atsansone

@parlough : All updates made. Believe this is G2G.

atsansone · 2023-11-13T18:17:26Z

+   {{envvarset}}FLUTTER_STORAGE_BASE_URL="https://storage.flutter-io.cn"
+   ```
+
+1. Download the Flutter archive from your mirror site.


A zip file or a tar file are archive file formats. Going to keep as-is.

atsansone · 2023-11-13T18:23:15Z

+The Flutter team cannot guarantee long-term availability of any mirrors.
+You can use other mirrors if they become available.


atsansone · 2023-11-13T18:27:38Z

@AlexV525 : Let me know if you have questions about the source files. Accounting for platform makes them a little tricky.

parlough

Thanks for continuing to work on this @atsansone!

I found a few issues that I think should be addressed before this lands, but I don't need to see it again after they are addressed. Unless you want to discuss some of them further, then feel free to tag me :)

As a side note, this PR should be auto staging to https://flutter-docs-prod--pr9338-fix-2556-92qeer86.web.app/community/china now.

parlough · 2023-11-14T05:03:45Z

I think this note should stay in English, or at least also provide the English version of this text (first and then Chinese), since it's scattered in a few locations across the website.

In my earlier mentions, I was thinking this note would stay the same and the Chinese version of the text would just be at the top of the "Using Flutter in China" page, for those that navigate there from this note or from searching. I still feel this is probably the better choice for our site.

parlough · 2023-11-14T05:07:44Z

+   {{envvarset}}FLUTTER_STORAGE_BASE_URL="https://storage.flutter-io.cn"
+   ```
+
+1. Download the Flutter archive from your mirror site.


That's technically true, but it's quite confusing since it uses "archive" to mean two different things in this same step. It reads as if it's telling me to download the entire archive page.

parlough · 2023-11-14T05:08:08Z

+   ```
+
+1. Download the Flutter archive from your mirror site.
+   In your preferred browser, go to


Suggested change

In your preferred browser, go to

In your preferred browser, go to the

parlough · 2023-11-14T05:09:54Z

+
+   ```terminal
+   {{unzip}} {{sdk | replace: "opsys", download-os}}{{file-format}}
+   ```


I recommend adding an extra sentence to explicitly explain that they need to use the exact name of the specific bundle they downloaded here. When there are terminal code blocks, readers often just copy paste without much consideration, or they may be new to this type of activity and may not know.

parlough · 2023-11-14T05:12:09Z

+From this example, `flutter pub get` fetches packages from `flutter-io.cn`,
+in any terminal where you set `PUB_HOSTED_URL` and `FLUTTER_STORAGE_BASE_URL`.


What do you intend to mean by "from this example"? "After completing the steps of this procedure"?

parlough · 2023-11-14T05:19:34Z

+
+### Download Flutter archives based on a mirrored URL
+
+To download Flutter archives from a mirrored URL,


I think this section is missing the context of where to get the original storage.googleapis.com links, which is necessary for the steps to work. Perhaps:

Suggested change

To download Flutter archives from a mirrored URL,

To download Flutter from the [SDK archive][] using a mirrored URL,

(and add the link definition).

parlough · 2023-11-14T05:23:33Z

+To change a Google storage site to a CFUG storage site, replace the example
+original URL with the example mirror URL.


I'm a bit lost on what this sentence is trying to do. Is it trying to act as an instruction? Or is trying to introduce the following example? I think it would help be more explicit if it's about the following example.

The following example shows how to update an example Flutter download URL from using Google's archive to using CFUG's mirror.

parlough · 2023-11-14T05:28:34Z

+{% comment %} Tab panes {% endcomment -%}
+<div class="tab-content">
+{% for os in page.os-list %}
+{% include_relative _download-urls.md ref-os=os filepath=sdk-path %}


This seems to be showing .tar.xz for the Windows tab and .zip for the Linux one.

parlough · 2023-11-14T05:29:23Z

+  Not every mirror supports downloading artifacts using their direct URL.
+{{site.alert.end}}
+
+## Configure your machine to publish your package


Suggested change

## Configure your machine to publish your package

## Configure your machine to publish a package

parlough · 2023-11-14T05:34:21Z

+To download Flutter archives from a mirrored URL,
+replace `storage.googleapis.com` with the URL of your trusted mirror.
+This should improve download speed.
+You can use the mirror URL in other applications to download software.


What kind of software is this referring to?

Dowload tools, such as IDM or Thunder (which is widely used in China)

Fixes flutter#2556 Staged at https://flutter-docs-prod--pr9338-fix-2556-92qeer86.web.app/community/china --------- Co-authored-by: Alex Li <github@alexv525.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>

atsansone requested review from parlough and sfshaza2 as code owners August 31, 2023 21:20

atsansone added the review.tech Awaiting Technical Review label Aug 31, 2023

parlough self-assigned this Sep 1, 2023

parlough reviewed Sep 1, 2023

View reviewed changes

atsansone added review.await-update Awaiting Updates after Edits and removed review.tech Awaiting Technical Review labels Sep 1, 2023

parlough assigned atsansone and unassigned parlough Sep 1, 2023

AlexV525 reviewed Sep 17, 2023

View reviewed changes

Comment thread src/community/china.md Outdated

atsansone added st.blocked Issue cannot continue until another action completes review.tech Awaiting Technical Review and removed review.await-update Awaiting Updates after Edits labels Sep 18, 2023

AlexV525 requested review from MaryaBelanger and domesticmouse as code owners October 26, 2023 06:10

atsansone force-pushed the fix-2556 branch 5 times, most recently from 781661e to 663172c Compare October 27, 2023 18:16

atsansone commented Oct 27, 2023

View reviewed changes

Comment thread src/community/china.md Outdated

Comment thread src/community/china.md Outdated

AlexV525 requested changes Oct 28, 2023

View reviewed changes

AlexV525 reviewed Oct 28, 2023

View reviewed changes

Comment thread src/community/china.md Outdated

skyzh reviewed Oct 29, 2023

View reviewed changes

Comment thread src/community/china.md Outdated

atsansone requested a review from khanhnwin as a code owner October 31, 2023 00:02

AlexV525 reviewed Oct 31, 2023

View reviewed changes

Comment thread src/community/china/_os-settings.md Outdated

Tony Sansone and others added 12 commits November 13, 2023 12:13

Add note about publishing from China

7d6f5aa

Update for Chinese Flutter install

d169ecc

Apply suggestions from code review from @AlexV525

93999f4

Co-authored-by: Alex Li <github@alexv525.com>

Update per @AlexV525 review

e9270d9

Apply suggestions from code review

199cb48

Co-authored-by: Alex Li <github@alexv525.com>

Made more changes per @AlexV525

2ba94c6

Apply suggestions from code review from @AlexV525

7e7f336

@AlexV525 : Great help on this. Thanks! Co-authored-by: Alex Li <github@alexv525.com>

Update src/community/china/index.md

250fd6f

Apply suggestions from code review from @AlexV525

70f0c48

Co-authored-by: Alex Li <github@alexv525.com>

Added TUNA

078b5cd

Update china-notice.md

551f432

Updates for platform

f63b25f

atsansone force-pushed the fix-2556 branch from c4ceb05 to f63b25f Compare November 13, 2023 18:13

atsansone commented Nov 13, 2023

View reviewed changes

Integrated last changes

c1967d7

atsansone removed the st.blocked Issue cannot continue until another action completes label Nov 13, 2023

Merge branch 'main' into fix-2556

a1d58e8

parlough approved these changes Nov 14, 2023

View reviewed changes

parlough added review.await-update Awaiting Updates after Edits and removed review.tech Awaiting Technical Review labels Nov 14, 2023

parlough assigned atsansone and unassigned AlexV525 and atsansone Nov 14, 2023

Updated per @parlough review

e7491d2

atsansone added st.RFM Ready to merge or land and removed review.await-update Awaiting Updates after Edits labels Nov 14, 2023

atsansone merged commit c6befe6 into flutter:main Nov 14, 2023


		To configure a proxy, check out the [Dart documentation on proxies][].

		[Dart documentation on proxies]: {{dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall

	[Dart documentation on proxies]: {{dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall
	[Dart documentation on proxies]: {{site.dart-site}}/tools/pub/troubleshoot#pub-get-fails-from-behind-a-corporate-firewall

		The Flutter team cannot guarantee long-term availability of any mirrors.
		You can use other mirrors if they become available.

	In your preferred browser, go to
	In your preferred browser, go to the

		From this example, `flutter pub get` fetches packages from `flutter-io.cn`,
		in any terminal where you set `PUB_HOSTED_URL` and `FLUTTER_STORAGE_BASE_URL`.


		### Download Flutter archives based on a mirrored URL

		To download Flutter archives from a mirrored URL,

	To download Flutter archives from a mirrored URL,
	To download Flutter from the [SDK archive][] using a mirrored URL,

		To change a Google storage site to a CFUG storage site, replace the example
		original URL with the example mirror URL.

	## Configure your machine to publish your package
	## Configure your machine to publish a package

Uh oh!

Conversation

atsansone commented Aug 31, 2023 • edited by parlough Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexV525 commented Oct 26, 2023

Uh oh!

atsansone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Oct 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atsansone commented Oct 29, 2023

Uh oh!

skyzh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Oct 31, 2023

Uh oh!

atsansone left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atsansone commented Nov 13, 2023

Uh oh!

parlough left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parlough Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

atsansone commented Aug 31, 2023 •

edited by parlough

Loading

parlough left a comment •

edited

Loading

parlough Nov 14, 2023 •

edited

Loading