Skip to content

SubHeader#29

Merged
daadu merged 12 commits into
masterfrom
feature/#26-subheader
Jun 5, 2020
Merged

SubHeader#29
daadu merged 12 commits into
masterfrom
feature/#26-subheader

Conversation

@daadu

@daadu daadu commented May 30, 2020

Copy link
Copy Markdown
Member

Closes #26

@daadu
daadu requested a review from WieFel May 30, 2020 20:18
@daadu

daadu commented May 30, 2020

Copy link
Copy Markdown
Member Author

@WieFel Can you please document BackdropSubHeader. I tried but failed to describe it properly.

daadu
daadu commented May 30, 2020
View reviewed changes
Comment thread lib/backdrop.dart Outdated
Comment thread lib/backdrop.dart
@daadu daadu assigned daadu and WieFel Jun 1, 2020
@daadu daadu added this to the v1.0 milestone Jun 1, 2020
@felixwortmann

felixwortmann commented Jun 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think it is good. I have two improvements though:

  1. There should be a bool to not show the subHeader when the FrontPanel is visible
  2. There should be a bool to hide the FloatingActionButton when the BackPanel is visible (since it overlays sometimes)

@felixwortmann

felixwortmann commented Jun 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I just implemented both of my proposed changes here

@daadu can you take a look and tell me what you think?

@daadu

daadu commented Jun 3, 2020

Copy link
Copy Markdown
Member Author

@felixwortmann We are planning to give callbacks in #30 so that this changes could be handled by user itself.

@daadu

daadu commented Jun 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@WieFel Is review complete for this PR?

@felixwortmann

felixwortmann commented Jun 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@daadu Seems good, that might be an even better way to handle this.

@WieFel

WieFel commented Jun 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@daadu sorry, I missed to press the "submit review" button :D

WieFel
WieFel requested changes Jun 4, 2020
View reviewed changes
Comment thread lib/backdrop.dart
Comment thread lib/backdrop.dart
Comment thread lib/backdrop.dart Outdated
@daadu
daadu requested a review from WieFel June 4, 2020 12:36
@daadu
- [BackdropSubHeader] padding defaults to `EdgeInsets.symmetric(verti…
1bab921 
…cal: 12.0, horizontal: 16.0)`

- [BackdropSubHeader] set `endIndent` to 16.0 for default `divider`
@daadu

daadu commented Jun 5, 2020

Copy link
Copy Markdown
Member Author

LGTM.

What about you ? @WieFel @felixwortmann

@felixwortmann

felixwortmann commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Same

@daadu
daadu merged commit 9c62adb into master Jun 5, 2020
@daadu
daadu deleted the feature/#26-subheader branch June 5, 2020 10:00
@daadu

daadu commented Jun 5, 2020

Copy link
Copy Markdown
Member Author

This feature has landed in v0.3.4 in pub.dev.

@daadu
daadu restored the feature/#26-subheader branch June 5, 2020 10:08
@daadu
daadu deleted the feature/#26-subheader branch June 5, 2020 10:30
@renovate renovate Bot mentioned this pull request May 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WieFel WieFel WieFel approved these changes
+1 more reviewer
@felixwortmann felixwortmann felixwortmann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@daadu daadu

@WieFel WieFel

Labels

None yet

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

Add Subheader option

3 participants

@daadu @felixwortmann @WieFel