[Bug]: Using `Share.shareXFiles` on Windows results in a `stack overflow`

[CaptainDario]

Platform

Windows 11

Plugin

share_plus

Version

4.5.3

Flutter SDK

3.3.4

Steps to reproduce

I am trying to use the share_plus plugin with the feedback package on windows. On Android my application works and opens the share dialog. However, on Window it crashes with a stack overflow.

Code Sample

dart
BetterFeedback.of(context).show((UserFeedback feedback) async {
  final Directory output = await getTemporaryDirectory();
  final String screenshotFilePath = '${output.path}/feedback.png';
  final File screenshotFile = File(screenshotFilePath);
  await screenshotFile.writeAsBytes(feedbackScreenshot);
  final screenshotFilePath = await writeImageToStorage(feedback.screenshot);
  Map<String, dynamic> t = (await DeviceInfoPlugin().deviceInfo).toMap();

  Share.shareXFiles(
    [XFile(screenshotFilePath)],
    text: "test",
    subject: "DaKanji $globalVersion - feedback",
    sharePositionOrigin: () {
      RenderBox? box = context.findRenderObject() as RenderBox?;
      return box!.localToGlobal(Offset.zero) & box.size;
    } (),
  );
}

### Logs

```shell
[#5865   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5866   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5867   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5868   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5869   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5870   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5871   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5872   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5873   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5874   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5875   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5876   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5877   SharePlatform.shareXFiles
package:share_plus_platform_interface/share_plus_platform_interface.dart:107
#5878   Share.shareXFiles
package:share_plus/share_plus.dart:182
#5879   DaKanjiDrawerState.build.<anonymous closure>.<anonymous closure>.<anonymous closure>
package:da_kanji_mobile/…/drawer/drawer.dart:329
#5880   _RootZone.runUnary (dart:async/zone.dart:1653:54)
#5881   _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#5882   Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:766:45)
#5883   Future._propagateToListeners (dart:async/future_impl.dart:795:13)
#5884   Future._completeWithValue (dart:async/future_impl.dart:566:5)
#5885   _RootZone.runUnary (dart:async/zone.dart:1653:54)
#5886   _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#5887   Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:766:45)
#5888   Future._propagateToListeners (dart:async/future_impl.dart:795:13)
#5889   Future._completeWithValue (dart:async/future_impl.dart:566:5)
#5890   Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:639:7)
#5891   _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#5892   _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

Flutter Doctor

[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [Version 10.0.22621.521], locale en-US)
    • Flutter version 3.3.4 on channel stable at C:\Users\Dario\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (4 days ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0

[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\Dario\AppData\Local\Android\sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.2.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32516.85
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] VS Code (version 1.72.0)
    • VS Code at C:\Users\Dario\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.50.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.521]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 105.0.5195.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 106.0.1370.37

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Checklist before submitting a bug

• I Google'd a solution and I couldn't find it
• I searched on StackOverflow for a solution and I couldn't find it
• I read the README.md file of the plugin
• I'm using the latest version of the plugin
• All dependencies are up to date with flutter pub upgrade
• I did a flutter clean
• I tried running the example project

[miquelbeltran]

Looks like the method is calling to itself rather than to the shareFiles method internally. This should be an easy fix.

As a temporary fix you can call shareFiles directly on Windows.

[CaptainDario]

I am not 100% sure but I think I tried this and it throws an "not implemented on windows" exception.
I can double check later today though.

[miquelbeltran]

Ah yes, it is not yet released but already landed on main: 8e051b4

[CaptainDario]

If this feature was added now, why is shareFile() marked as deprecated?

[CaptainDario]

@miquelbeltran I added the plugin to my pubspec as

  share_plus: 
    git:
      url: https://github.com/fluttercommunity/plus_plugins.git
      path: packages/share_plus/share_plus
      ref: 8e051b4

However, I am still getting

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: UnimplementedError: shareFiles() has not been implemented on Windows.
#0      ShareWindows.shareFiles (package:share_plus_windows/share_plus_windows.dart:53:5)
#1      Share.shareFiles (package:share_plus/share_plus.dart:79:22)
#2      DaKanjiDrawerState.build.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:da_kanji_mobile/view/drawer/drawer.dart:329:41)
<asynchronous suspension>
#3      FeedbackWidgetState.sendFeedback.<anonymous closure> (package:feedback/src/feedback_widget.dart:315:9)
<asynchronous suspension>
#4      FeedbackWidgetState.sendFeedback (package:feedback/src/feedback_widget.dart:304:5)
<asynchronous suspension>
#5      FeedbackWidgetState._sendFeedback (package:feedback/src/feedback_widget.dart:339:5)
<asynchronous suspension>
#6      FeedbackWidgetState.build.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:feedback/src/feedback_widget.dart:261:33)
<asynchronous suspension>

[miquelbeltran]

If this feature was added now, why is shareFile() marked as deprecated?

Two different people worked on different features (web share support and windows share support) and so the API needs a bit of cleanup.

The shareXFile method should be preferred in the future, as it is a "true" cross-platform solution, and it should call internally shareFile, so this needs to be fixed for Windows.

A PR fixing this is more than welcome!

However, I am still getting

No idea, when we reviewed the feature, the example code worked.

[CaptainDario]

If I am able to fix this I will open a PR. I will look into it today.

[CaptainDario]

@miquelbeltran I looked at the code and shareFiles on windows has no implementation

plus_plugins/packages/share_plus/share_plus_windows/lib/share_plus_windows.dart

Lines 49 to 61 in 7b6ac7e

	/// Share files.
	@override
	Future<void> shareFiles(
	List<String> paths, {
	List<String>? mimeTypes,
	String? subject,
	String? text,
	Rect? sharePositionOrigin,
	}) {
	throw UnimplementedError(
	'shareFiles() has not been implemented on Windows.');
	}
	}

[miquelbeltran]

I believe that's the fallback implementation for older versions of windows, as the top of the file says, but I need to look again into it. Are you on Windows 10 or 11?