CI doesn't check if plugins build properly

[vbuberen]

It seems that job build_examples_dart is configured in a wrong way, so build fails on individual platforms aren't breaking builds and show step as successful in any case. For example, due to this configuration issue it is not detected that #495 broke examples on Android (see the attached screenshot).

I believe that failing on one of platforms should fail the whole job.

[mhadaily]

That's a good catch, are you up for a PR to fix it? or should I do that?

[vbuberen]

I will give it a try and write back in case I have issues fixing it.

[juliansteenbakker]

It seems indeed that building of example apps is failing because of this, but it doesn't get detected.

As for fixing the build issue, i think we need to add the following to the build action:

- uses: actions/setup-java@v2
  with:
    java-version: '11'

[juliansteenbakker]

After some research I think the problem with not failing is that melos run build:all always returns success. It seems that only melos exec returns failed status.

[vbuberen]

After some research I think the problem with not failing is that melos run build:all always returns success. It seems that only melos exec returns failed status.

This is what I reported. Not sure what your finding exactly about.

[vbuberen]

Please note that I am already working on updating this workflow

[juliansteenbakker]

I didn't catch that it was happening in melos run build:all, good work nonetheless

[juliansteenbakker]

#527 will fix the build process and make it pass all jobs.